Skip to content

P5AP-176-integration-updateMockData #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 188 commits into
base: develop
Choose a base branch
from
Open

P5AP-176-integration-updateMockData #55

wants to merge 188 commits into from

Conversation

@Hotblueice777
Copy link

@Hotblueice777 Hotblueice777 commented Oct 26, 2024

JIRA Ticket link: PC-xx

Type of change

  • Bug fix
  • [] New feature
  • [X ] Refactoring

Description

  • Changes made?
    undate mockDataForPhotocard.js，now each click can effectively display a different photo.
  • Reason for changes?
  • Behavior before?
  • Behavior after?
  • How did you test?

Checklist

  • [x ] I have performed a self-review of my code.
  • [x ] I have manually tested the new feature and found it to be working as expected.
  • [x ] All commits in this PR are related to the issue.
  • [x ] Base branch for this PR is set to develop.
  • [x ] JIRA ticket # and my initials are noted in this PR's name (format example: #57-EB Add Pull Request template)

Reminder: every PR needs at least 1 peer approval before merging to the develop branch. Once a main ticket has been completed, along with all subtasks, associated code can be merged to main.

ToluAjisola and others added 30 commits September 26, 2024 22:13
@ToluAjisola
Moved RoadMap mock data to diffirent folder and file
fd3c693
@ToluAjisola
Detached relaince on the mock data's user image assignment and replac…
fa5a5f4 
…ed it with the React Hook for user images
@ToluAjisola
Made changes according to peer code review
dd6fa7c
@ToluAjisola
Added fallback image for matched image
8ebd28b
@alinix1
rename and move backend folder
594b030
@ToluAjisola
User image source change
c9ee328
@ToluAjisola
Merge pull request #1 from makeitMVPadmin/accoutapair-P5AP-74-Code-Re…
f3ef832 
…factoring

Moved RoadMap mock data to different folder and file
@ToluAjisola
Temporary landing page
973074d
@ToluAjisola
Removed unsed imports
7a4f238
@alinix1
add proper error handling for CRUD operations
f7636b3
@alinix1
add button type to onClick event handler
3637bb5
@alinix1
centralize logic for fetch and state update
931adda
@jagadeepavula
Merge pull request #2 from makeitMVPadmin/accoutapair-P5AP-74-Code-Re…
23d98c3 
…factoring

P5AP-74-Code-Refactoring T.A, Temporary landing page
@alinix1
remove comments and console logs
45c7475
@alinix1
remove console log from render and add check for data existence in th…
818e538 
…e return
@alinix1
destructure id, firstName, description
26d7e41
@alinix1
refactor handleCreate to avoid unnecessary fetch calls after data cre…
fad890a 
…ation
@alinix1
refactor handleUpdate to update state directly without re-fetching data
099b4af
@alinix1
add constants.js file to /src folder
b5775e7
@alinix1
remove try/catch block for simpler and cleaner data fetching
c92e92a
@alinix1
refactor magic string and use constants.js
31eb0fb
@TimWallaceDev
update readme
d51bc05
@alinix1
update welcome message and button text in prompt page
9e04f98
@alinix1
update global styles
5a83ee9
@alinix1
update button component: add border prop, adjust font and layout in S…
75e0249 
…CSS file
@alinix1
update PromptPage component: adjust button colors and borders, refine…
0af838e 
… layout and spacing in SCSS
@alinix1
refactor PromptPage component - comment out unused assets, styles, an…
de3b442 
…d layout
@alinix1
update PromptPage styles
054544b
@alinix1
update global styles: refine typography within global SCSS file
cce4bce
@alinix1
swap event listeners for Continue and Back to home buttons in PromptPage
9f21d66
Hotblueice777 and others added 30 commits October 24, 2024 01:16
@Hotblueice777
renew pairuppage button
7005b3d
@jagadeepavula
Merge pull request #23 from makeitMVPadmin/P5AP-157-task-bar-component
243b22c 
TJ - P5 ap 157 task bar component
@Hotblueice777
delete comments form files, keep code clean
2314836
@Hotblueice777
To check for conflicts, I merge develop into my branch and check that…
416747c 
… there are no conflicts
@jagadeepavula
added margin top for button to match figma design
ba51cc3
@jagadeepavula
Merge pull request #25 from makeitMVPadmin/frontend-challenge-card-up…
b8fff03 
…date

AN-Frontend challenge card update
@TimWallaceDev
create challenge details button with modal
850c08d
@TimWallaceDev
Merge branch 'develop' into P5-AP-task-page-detailed-instuctions
851ccf3
@Hotblueice777
modify the panel, change board colorto black, add infoIcon on buttonw…
f4ca758 
…ithpanel
@Hotblueice777
add clse Icon on the panel
268639a
@Hotblueice777
Modify button style
af48ae3
@Hotblueice777
Merge branch 'develop' into P5AP-146-component-photocard
74d3f45
@ToluAjisola
Update README.md
e1ccb85
@Hotblueice777
add backend function matchUser.js, integrated challengeDetailPage to …
5c3cf84 
…PairupPage by pairuo button, loading matched user data successfully.
@Hotblueice777
renew mockDatas
6efc702
@Hotblueice777
nothing change
d21095d
@jagadeepavula
Merge pull request #27 from makeitMVPadmin/Updated-README.md---TA
d89b129 
Update README.md
@jagadeepavula
Merge pull request #11 from makeitMVPadmin/P5AP-146-component-photocard
4a2c833 
P5AP-146-component-photocard
@jagadeepavula
importing profile picture correctly
0b80feb
@jagadeepavula
Merge pull request #29 from makeitMVPadmin/P5AP-integrating-details-p…
1453f70 
…airup

importing profile picture correctly
@jagadeepavula
Merge branch 'develop' into P5-AP-task-page-detailed-instuctions
4055a29
@jagadeepavula
Merge pull request #26 from TimWallaceDev/P5-AP-task-page-detailed-in…
dcf9389 
…stuctions

P5 ap task page detailed instuctions
@jagadeepavula
Refactoring
90d7573
@Hotblueice777
Merge branch 'P5AP-170-Integration-Match' into develop
d45bc95
@Hotblueice777
merge P5AP-170-Integration-Match, fix a few code in matchUser.js
e0a0869
@ToluAjisola
Update main.js, changed AccountaBuddy to AccountaPair
18be540
@laxmik1112
Resolved the review comments and fixed the stepper button color
ace779b
@laxmik1112
Merge branch 'develop' into P5AP-157-frontend-pages-challenge-task-bo…
2b10caa 
…ard-Integration
@laxmik1112
Merge pull request #22 from makeitMVPadmin/P5AP-157-frontend-pages-ch…
f6e96b5 
…allenge-task-board-Integration

P5 ap 157 frontend pages challenge task board integration
@Hotblueice777
undate mockDataForPhotocard.js
2b98543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Hotblueice777 @ToluAjisola @alinix1 @jagadeepavula @TimWallaceDev @laxmik1112 @truittjanney