Merge pull request #293 from makinacorpus/fix_others_colors

fix: revert fixing current object order in overlays menu (#292)
makinacorpus · Apr 2, 2024 · aa6b98b · aa6b98b
2 parents 8a6f589 + 4a1a85b
commit aa6b98b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -8,6 +8,7 @@ CHANGELOG
 
 - Form clearing not handling number fields
 - Fix weasyprint html public view by converting file:// schemes with http://
+- Revert fixing current object order in overlays menu (#292)
 
 
 8.7.2  (2024-03-22)

diff --git a/mapentity/static/mapentity/mapentity.detail.js b/mapentity/static/mapentity/mapentity.detail.js
@@ -33,12 +33,6 @@ $(document).ready(function () {
         });
         map.layerscontrol.addOverlay(layer, objectsname, verbosename);
 
-        // Change the group layer "verbosename" (current object list) in first position
-        var allOverlaysLayers = document.getElementsByClassName('leaflet-control-layers-overlays')[0];
-        if (allOverlaysLayers) {
-            allOverlaysLayers.insertBefore(allOverlaysLayers.lastChild, allOverlaysLayers.firstChild);
-        }
-
         // Add object family layer (without current object) 
         map.on('layeradd', function (e) {
             var options = e.layer.options || { 'modelname': 'None' };

diff --git a/mapentity/static/mapentity/mapentity.forms.js b/mapentity/static/mapentity/mapentity.forms.js
@@ -73,10 +73,6 @@ MapEntity.GeometryField = L.GeometryField.extend({
         var nameHTML = '<span style="color: '+ style['color'] + ';">&#x25A3;</span>&nbsp;' + objectsname;
         map.layerscontrol.addOverlay(objectsLayer, nameHTML, tr("Objects"))
 
-        // Change the group layer "Objects" (current object list) in first position
-        var allOverlaysLayers = document.getElementsByClassName('leaflet-control-layers-overlays')[0];
-        allOverlaysLayers.insertBefore(allOverlaysLayers.lastChild, allOverlaysLayers.firstChild);
-
         var url = this.modelLayerUrl();
         objectsLayer.load(url);
     },

diff --git a/mapentity/static/mapentity/mapentity.map.js b/mapentity/static/mapentity/mapentity.map.js
@@ -348,10 +348,6 @@ $(window).on('entity:map:list', function (e, data) {
         }
     );
 
-    // Change the group layer "Objects" (current object list) in first position
-    var allOverlaysLayers = document.getElementsByClassName('leaflet-control-layers-overlays')[0];
-    allOverlaysLayers.insertBefore(allOverlaysLayers.lastChild, allOverlaysLayers.firstChild);
-
     $(window).unload(function () {
         MapEntity.Context.saveFullContext(map, {
             filter: '#mainfilter',