fix: change a balise to button balise on create or update button

makinacorpus · Jul 29, 2024 · cd7c4c2 · cd7c4c2
1 parent e7ddc35
commit cd7c4c2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,9 @@ CHANGELOG
 8.9.2+dev  (XXXX-XX-XX)
 -----------------------
 
+**Bug fixes**
+
+- Change a balise to button balise on create or update button
 
 
 8.9.2      (2024-07-15)

diff --git a/mapentity/forms.py b/mapentity/forms.py
@@ -85,11 +85,12 @@ def populate_fields(self):
 class SubmitButton(HTML):
 
     def __init__(self, div_id, label):
+        # onclik is here to bypass html5 validation
         content = ("""
-            <a id="{0}" class="btn btn-success"
-               onclick="javascript:$(this).parents('form').submit();">
+            <button type="submit" id="{0}" class="btn btn-success"
+                   onclick="this.form.submit();">
                 <i class="bi bi-check-circle-fill"></i> {1}
-            </a>""".format(div_id, label))
+            </button>""".format(div_id, label))
         super().__init__(content)