Fix new internal user cache #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcantoinedupre
force-pushed
the
hotfix_internal_user_cache
branch
from
28f8687
to
51b5fc7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 90.98% 91.00% +0.01%
==========================================
Files 32 32
Lines 2397 2402 +5
==========================================
+ Hits 2181 2186 +5
Misses 216 216 ☔ View full report in Codecov by Sentry. |
The `get_internal_user` function was broken: - on first use when the key for the internal user pk is not in the cache => the get_or_create would not work because there is no user with ID 0 (get fails) and the unique username is already in use (create fails). The try/except around `internal_user = User.objects.get(pk=id)` was added to make the tests pass. Maybe a concurrency issue/a transaction issue?
marcantoinedupre
force-pushed
the
hotfix_internal_user_cache
branch
from
51b5fc7
to
5c7b9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_internal_userfunction was broken: