Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change a balise to button balise on create or update button #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: change a balise to button balise on create or update button #307

wants to merge 1 commit into from

Conversation

juggler31
Copy link
Contributor

No description provided.

@juggler31 juggler31 requested a review from submarcos July 24, 2024 14:17
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (e7ddc35) to head (9803ca9).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          32       32           
  Lines        2403     2403           
=======================================
  Hits         2187     2187           
  Misses        216      216

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 force-pushed the contraint_create_button branch 3 times, most recently from 92bc9ab to b99f953 Compare July 29, 2024 09:50
@juggler31 juggler31 changed the title fix: add contraint to click only once on create buttons fix: change a balise to button balise on create or update button Jul 29, 2024
@juggler31 juggler31 force-pushed the contraint_create_button branch 2 times, most recently from a568f68 to cd7c4c2 Compare July 29, 2024 10:24
@juggler31 juggler31 linked an issue Jul 29, 2024 that may be closed by this pull request
Fix posibility to click more than one time in create or save button #308
Open
marcantoinedupre
marcantoinedupre approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

I suggest to rephrase the PR title and the changelog item as: "Use HTML tag for create/update button"

It is not really a bugfix, is it? More like an improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

@submarcos submarcos Awaiting requested review from submarcos

Assignees
No one assigned
Labels
bug refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix posibility to click more than one time in create or save button
2 participants
@juggler31 @marcantoinedupre