more quoting

mtoy-googly-moogly · mtoy-googly-moogly · commit 11a25e839802 · 2024-11-29T12:40:01.000-08:00
diff --git a/packages/malloy/src/dialect/snowflake/snowflake.ts b/packages/malloy/src/dialect/snowflake/snowflake.ts
@@ -310,8 +310,9 @@ export class SnowflakeDialect extends Dialect {
   sqlSelectAliasAsStruct(alias: string): string {
     return `OBJECT_CONSTRUCT_KEEP_NULL(${alias}.*)`;
   }
+
   sqlMaybeQuoteIdentifier(identifier: string): string {
-    return `"${identifier}"`;
+    return '"' + identifier.replace(/"/g, '""') + '"';
   }
 
   sqlCreateTableAsSelect(tableName: string, sql: string): string {

Original file line number	Diff line number	Diff line change
`@@ -310,8 +310,9 @@ export class SnowflakeDialect extends Dialect {`
`310`	`310`	`sqlSelectAliasAsStruct(alias: string): string {`
`311`	`311`	return `OBJECT_CONSTRUCT_KEEP_NULL(${alias}.*)`;
`312`	`312`	`}`
	`313`	`+`
`313`	`314`	`sqlMaybeQuoteIdentifier(identifier: string): string {`
`314`		- return `"${identifier}"`;
	`315`	`+ return '"' + identifier.replace(/"/g, '""') + '"';`
`315`	`316`	`}`
`316`	`317`
`317`	`318`	`sqlCreateTableAsSelect(tableName: string, sql: string): string {`