inherit array most places

Author: mtoy-googly-moogly

packages/malloy/src/dialect/duckdb/duckdb.ts

@@ -448,11 +448,6 @@ export class DuckDBDialect extends PostgresBase {
     return `DATE_SUB('${df.units}', ${lVal}, ${rVal})`;
   }
 
-  sqlLiteralArray(lit: ArrayLiteralNode): string {
-    const array = lit.kids.values.map(val => val.sql);
-    return '[' + array.join(',') + ']';
-  }
-
   sqlLiteralRecord(lit: RecordLiteralNode): string {
     const pairs = Object.entries(lit.kids).map(
       ([propName, propVal]) =>

packages/malloy/src/dialect/pg_impl.ts

@@ -102,7 +102,8 @@ export abstract class PostgresBase extends Dialect {
     throw new Error('Cannot create a record literal for postgres base dialect');
   }
 
-  sqlLiteralArray(_lit: ArrayLiteralNode): string {
-    throw new Error('Cannot create array literal for postgres base dialect');
+  sqlLiteralArray(lit: ArrayLiteralNode): string {
+    const array = lit.kids.values.map(val => val.sql);
+    return 'ARRAY[' + array.join(',') + ']';
   }
 }

packages/malloy/src/dialect/postgres/postgres.ts

@@ -33,7 +33,6 @@ import {
   MeasureTimeExpr,
   LeafAtomicTypeDef,
   RecordLiteralNode,
-  ArrayLiteralNode,
 } from '../../model/malloy_types';
 import {
   DialectFunctionOverloadDef,
@@ -455,9 +454,4 @@ export class PostgresDialect extends PostgresBase {
     }
     return `JSONB_BUILD_OBJECT(${props.join(', ')})`;
   }
-
-  sqlLiteralArray(lit: ArrayLiteralNode): string {
-    const array = lit.kids.values.map(val => val.sql);
-    return `ARRAY[${array.join(',')}]`;
-  }
 }

packages/malloy/src/dialect/trino/trino.ts

@@ -37,7 +37,6 @@ import {
   TimeExtractExpr,
   LeafAtomicTypeDef,
   TD,
-  ArrayLiteralNode,
   RecordLiteralNode,
   isAtomic,
 } from '../../model/malloy_types';
@@ -638,11 +637,6 @@ ${indent(sql)}
     return from.units === 'day_of_week' ? `mod(${extracted}+1,7)` : extracted;
   }
 
-  sqlLiteralArray(lit: ArrayLiteralNode): string {
-    const array = lit.kids.values.map(val => val.sql);
-    return 'ARRAY[' + array.join(',') + ']';
-  }
-
   sqlLiteralRecord(lit: RecordLiteralNode): string {
     const rowVals: string[] = [];
     const rowTypes: string[] = [];