-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace $.trim() with String.prototype.trim() #848
Comments
I will work on my fork I maintain to incorporate this fix. Thank you for heads up - as it appears this master branch is unmaintained... |
Thank you, can you please let me know when updated. Does this also mean
that the fix will apply automatically or do we need to get a developer to
fix the jquery?
With appreciation,
Eileen.
…On Thu, Sep 17, 2020 at 1:20 PM sysop ***@***.***> wrote:
I will work on my fork I maintain to incorporate this fix. Thank you for
heads up - as it appears this master branch is unmaintained...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#848 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5CCCB7CK2XU5DNLR3ANJ3SGF56FANCNFSM4MOVKJXA>
.
|
I have updated my branch with changes as noted. Fixes include updates to support jQuery 3.x+ in the installation. https://github.com/thecarnie/cycle2/releases/tag/2.1.6b Testing and verification IS REQUIRED before putting into production. |
Just wanted to say thanks @thecarnie ! |
$.trim()
is deprecated in jQuery 3.5.0Upgrading jQuery is now a bit of a breaking change for cycle2 as far as I can see.
The text was updated successfully, but these errors were encountered: