Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $.trim() with String.prototype.trim() #848

Open
miclgael opened this issue Apr 23, 2020 · 4 comments
Open

Replace $.trim() with String.prototype.trim() #848

miclgael opened this issue Apr 23, 2020 · 4 comments

Comments

@miclgael
Copy link

$.trim() is deprecated in jQuery 3.5.0

Upgrading jQuery is now a bit of a breaking change for cycle2 as far as I can see.

@iam-sysop
Copy link

I will work on my fork I maintain to incorporate this fix. Thank you for heads up - as it appears this master branch is unmaintained...

@EileenWeb
Copy link

EileenWeb commented Sep 17, 2020 via email

@iam-sysop
Copy link

I have updated my branch with changes as noted. Fixes include updates to support jQuery 3.x+ in the installation.

https://github.com/thecarnie/cycle2/releases/tag/2.1.6b

Testing and verification IS REQUIRED before putting into production.

@miclgael
Copy link
Author

Just wanted to say thanks @thecarnie !
I'll leave this issue open so others can see, and hopefully one day your changes will be able to be merged. hah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants