Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with latest wordpress update #851

Open
EileenWeb opened this issue Aug 25, 2020 · 7 comments
Open

issues with latest wordpress update #851

EileenWeb opened this issue Aug 25, 2020 · 7 comments

Comments

@EileenWeb
Copy link

Hi,

There appears to be an issue with cycle2 and the latest wordpress update. I don't know if anyone else is having the same problem? We have been told that cycle2 would need to be upgraded (custom code in place on website). Is this necessary to upgrade? Happy to share the site that has cycle2, privately.

Thanks, Eileen.

@EileenWeb
Copy link
Author

Anyone from Cycle2 able to answer this?

@iam-sysop
Copy link

Most likely you have issue from jQuery changes that have affected Cycle2.

jQuery 3 had breaking changes that affect Cycle2 operation.

Some forks (including one I maintain) have fixes to support Cycle2 with newer jQuery versions (3.x +).

**NOTE: Personally I do not support WordPress in any fashion - the updated files on my fork MAY help someone with experience updating "parts" of a wordpress site or plugin manually.

Fork here: https://github.com/thecarnie/cycle2

@iam-sysop
Copy link

I have updated my branch with changes as noted. Fixes include updates to support jQuery 3.x+ in the installation.

https://github.com/thecarnie/cycle2/releases/tag/2.1.6b

Testing and verification IS REQUIRED before putting into production.

@webimagedesigns
Copy link

webimagedesigns commented Jan 21, 2021

jQuery.type and jQuery.isFunction() are being flagged as deprecated by jQuery Migrate in WordPress 5.6 for jquery.cycle2.min.js. I am using jQuery.cycle2.min.js
/*!

@iam-sysop
Copy link

Thank you - I will investigate and push updates!

@webimagedesigns
Copy link

webimagedesigns commented Jan 22, 2021 via email

@iam-sysop
Copy link

An updated release with noted changes has been published downstream on my fork of cycle2.

Multiple fixes, patches, cleanups, and updates throughout.

See https://github.com/thecarnie/cycle2/master for details and commit history.

Brings current with all patches found and applied either in this repo or downstream in mine. I will assemble proper upstream pull request next for inclusion here.

Release bundle available at my fork here:

https://github.com/thecarnie/cycle2/releases/tag/2.1.6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants