Skip to content

Commit 75ed893

Browse files
committed
Don't run stress tests on Windows
1 parent a21f35b commit 75ed893

7 files changed

+22
-1
lines changed

cpp/arcticdb/util/min_max_float.hpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,14 @@ T find_float_max(const T* data, size_t n) {
7878
template<typename T>
7979
typename std::enable_if<std::is_floating_point<T>::value, T>::type
8080
find_float_min(const T *data, size_t n) {
81+
util::check(size != 0, "Got zero size in find_float_min");
8182
return *std::min_element(data, data + n);
8283
}
8384

8485
template<typename T>
85-
typename std::enable_if<std::is_integral<T>::value, T>::type
86+
typename std::enable_if<std::is_floating_point<T>::value, T>::type
8687
find_float_max(const T *data, size_t n) {
88+
util::check(size != 0, "Got zero size in find_float_max");
8789
return *std::max_element(data, data + n);
8890
}
8991

cpp/arcticdb/util/min_max_integer.hpp

+2
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,14 @@ MinMax<T> find_min_max(const T* data, size_t n) {
117117
template<typename T>
118118
typename std::enable_if<std::is_integral<T>::value, T>::type
119119
find_min(const T *data, size_t n) {
120+
util::check(size != 0, "Got zero size in find_min");
120121
return *std::min_element(data, data + n);
121122
}
122123

123124
template<typename T>
124125
typename std::enable_if<std::is_integral<T>::value, T>::type
125126
find_max(const T *data, size_t n) {
127+
util::check(size != 0, "Got zero size in find_max");
126128
return *std::max_element(data, data + n);
127129
}
128130

cpp/arcticdb/util/sum.hpp

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ double find_sum(const T* data, size_t n) {
8282

8383
template<typename T>
8484
double find_sum(const T *data, size_t n) {
85+
util::check(size != 0, "Got zero size in find_sum");
8586
return std::accumulate(data, data + n, T(0));
8687
}
8788

cpp/arcticdb/util/test/test_mean.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@ TEST_F(MeanFinderTest, ExtremeDoubleAverage) {
166166
EXPECT_DOUBLE_EQ(find_mean(data.data(), data.size()), 0.0);
167167
}
168168

169+
#ifdef HAS_VECTOR_EXTENSIONS
170+
169171
TEST_F(MeanFinderTest, LargeArrayPerformance) {
170172
constexpr size_t size = 100'000'000;
171173
auto data = create_aligned_data<int32_t>(size);
@@ -194,4 +196,6 @@ TEST_F(MeanFinderTest, LargeArrayPerformance) {
194196
EXPECT_NEAR(simd_mean, std_mean, 1e-10);
195197
}
196198

199+
#endif
200+
197201
} // namespace arcticdb

cpp/arcticdb/util/test/test_min_max_float.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ TEST_F(FloatFinderTest, VectorWithNaNs) {
5454
EXPECT_FLOAT_EQ(find_float_max(data.data(), data.size()), 62.0f);
5555
}
5656

57+
#ifdef HAS_VECTOR_EXTENSIONS
58+
5759
TEST_F(FloatFinderTest, LargeArrayPerformance) {
5860
constexpr size_t size = 100'000'000;
5961
auto data = create_aligned_data<float>(size);
@@ -83,6 +85,8 @@ TEST_F(FloatFinderTest, LargeArrayPerformance) {
8385
EXPECT_FLOAT_EQ(max_result, *std_result_max);
8486
}
8587

88+
#endif
89+
8690
TEST_F(FloatFinderTest, EmptyInputFloat) {
8791
std::vector<float> data;
8892
EXPECT_FLOAT_EQ(find_float_min(data.data(), 0), std::numeric_limits<float>::infinity());

cpp/arcticdb/util/test/test_min_max_integer.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,8 @@ TEST(MinMaxFinder, Stress) {
284284
EXPECT_EQ(result.max, *std_result.second);
285285
}
286286

287+
#ifdef HAS_VECTOR_EXTENSIONS
288+
287289
class MinMaxStressTest : public ::testing::Test {
288290
protected:
289291
std::mt19937_64 rng{std::random_device{}()};
@@ -484,4 +486,6 @@ TEST_F(MinMaxStressTest, UnalignedSize) {
484486
run_benchmark(data, "Unaligned Size");
485487
}
486488

489+
#endif
490+
487491
} //namespace arcticdb

cpp/arcticdb/util/test/test_sum.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ TEST_F(SumFinderTest, SingleElementFloat) {
8282
EXPECT_NEAR(find_sum(data.data(), data.size()), 3.37, 1e-6);
8383
}
8484

85+
#ifdef HAS_VECTOR_EXTENSIONS
86+
8587
class SumStressTest : public ::testing::Test {
8688
protected:
8789
std::mt19937_64 rng{std::random_device{}()};
@@ -251,4 +253,6 @@ TEST_F(SumStressTest, ExtremeValues) {
251253
run_benchmark(data, "Extreme Values");
252254
}
253255

256+
#endif
257+
254258
} // namespace arcticdb

0 commit comments

Comments
 (0)