Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We're not running all the evm tests #434

Closed
MattMSumner opened this issue Sep 19, 2018 · 4 comments
Closed

We're not running all the evm tests #434

MattMSumner opened this issue Sep 19, 2018 · 4 comments
Labels
evm

Comments

@MattMSumner
Copy link
Contributor

No description provided.

@MattMSumner
Copy link
Contributor Author

This could lead to a regression. We're not running them all since it will time out CI. I think we could resolve this by parallelizing the tests.

@hayesgm
Copy link
Contributor

hayesgm commented Oct 29, 2018

Which tests are not being run? Can we verify if/if not this is still true?

@MattMSumner
Copy link
Contributor Author

It looks like like some of the "performance" tests are being skipped: https://github.com/mana-ethereum/mana/blob/master/apps/evm/test/evm_test.exs#L19-L40

@hayesgm
Copy link
Contributor

hayesgm commented Nov 2, 2018

In that case, let's close this issue in lieu of #565 to run those tests

@hayesgm hayesgm closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hayesgm @MattMSumner