Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing TODOs #581

Open
InoMurko opened this issue Nov 6, 2018 · 0 comments
Open

addressing TODOs #581

InoMurko opened this issue Nov 6, 2018 · 0 comments

Comments

@InoMurko
Copy link
Member

InoMurko commented Nov 6, 2018

mix credo --strict would show:

`
Software Design

┃ [D] → Found a TODO tag in a comment: # TODO: Handle args, make nicer
┃ apps/evm/lib/evm/debugger.ex:327 #(EVM.Debugger.handle_prompt)
┃ [D] → Found a TODO tag in a comment: # TODO: Does this log mess up our
┃ progress tracker?
┃ apps/cli/lib/sync.ex:52 #(CLI.Sync.sync_new_blocks)
┃ [D] → Found a TODO tag in a comment: # TODO: Check we can't extend the ext?
┃ apps/merkle_patricia_tree/lib/merkle_patricia_tree/trie/verifier.ex:87 #(MerklePatriciaTree.Trie.Verifier.verify_node)
┃ [D] → Found a TODO tag in a comment: # TODO: Decide if we want to waste the
┃ cycles to pull
┃ apps/blockchain/lib/blockchain/account.ex:416 #(Blockchain.Account.transfer)
┃ [D] → Found a TODO tag in a comment: # TODO: Implement CMAC
┃ apps/exth_crypto/lib/exth_crypto/mac.ex:36 #(ExthCrypto.MAC.mac)
┃ [D] → Found a TODO tag in a comment: # TODO: SEC1 - §5.1.4 - Steps 2, 3 -
┃ Verify curve
┃ apps/exth_crypto/lib/exth_crypto/ecies.ex:173 #(ExthCrypto.ECIES.decrypt)
┃ [D] → Found a TODO tag in a comment: # TODO: Bulk up these requests?
┃ apps/ex_wire/lib/ex_wire/sync.ex:87 #(ExWire.Sync.handle_info)
┃ [D] → Found a TODO tag in a comment: # TODO: reason?
┃ apps/ex_wire/lib/ex_wire/handshake.ex:316 #(ExWire.Handshake.read_ack_resp)
┃ [D] → Found a TODO tag in a comment: # TODO: We should read the header? But,
┃ it's unused by all clients.
┃ apps/ex_wire/lib/ex_wire/framing/frame.ex:128 #(ExWire.Framing.Frame.unframe)
┃ [D] → Found a TODO tag in a comment: # TODO: Use highest known block as limit?
┃ apps/cli/lib/cli.ex:41 #(CLI.sync)
┃ [D] → Found a TODO tag in a comment: # TODO: Do we have a standard for default
┃ account values
┃ apps/blockchain/lib/blockchain/account.ex:517 #(Blockchain.Account.get_machine_code)
┃ [D] → Found a TODO tag in a comment: # TODO: Deserialize from proper struct
┃ apps/ex_wire/lib/ex_wire/packet/transactions.ex:64 #(ExWire.Packet.Transactions.deserialize)
┃ [D] → Found a TODO tag in a comment: # TODO: Serialize accurately
┃ apps/ex_wire/lib/ex_wire/packet/transactions.ex:44 #(ExWire.Packet.Transactions.serialize)
┃ [D] → Found a TODO tag in a comment: # TODO: We need to follow up on
┃ disconnection packets with disconnection ourselves
┃ apps/ex_wire/lib/ex_wire/packet/status.ex:158 #(ExWire.Packet.Status.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: Track RTT time
┃ apps/ex_wire/lib/ex_wire/packet/pong.ex:59 #(ExWire.Packet.Pong.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: Do something
┃ apps/ex_wire/lib/ex_wire/packet/new_block_hashes.ex:85 #(ExWire.Packet.NewBlockHashes.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: Add a bunch more checks
┃ apps/ex_wire/lib/ex_wire/packet/hello.ex:120 #(ExWire.Packet.Hello.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: Do.
┃ apps/ex_wire/lib/ex_wire/packet/block_headers.ex:79 #(ExWire.Packet.BlockHeaders.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: This is a simple way to determine
┃ who to send the message to,
┃ apps/ex_wire/lib/ex_wire/network.ex:108 #(ExWire.Network.handle)
┃ [D] → Found a TODO tag in a comment: # TODO: 64-bit hash?
┃ apps/evm/lib/block/header.ex:64 #(Block.Header)
┃ [D] → Found a TODO tag in a comment: # TODO: Add real tests here
┃ apps/evm/test/evm/operation/metadata_test.exs:5 #(EVM.Operation.MetadataTest)
┃ [D] → Found a TODO tag in a comment: # TODO: This should be set and stored in
┃ a file

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant