-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency issues with Scikit-bio #7
Comments
Since its required only for the plotting of memo outputs we could:
To be discussed with @ArnaudGaudry |
I am open to discussion about it, but I still think memo would be more attractive if people can have a quick look at their data without having to install any other package or define a plotting function. It doesn't cover all the possibilities of downstream analyses of course, but gives easily a first idea of what's possible. |
I agree, it would be nicer to have all in one package. So we should try that first. Even in such a case, the visualization part does not have to be removed completely. I would make it optional which with pip means that all code will be installed, but the visualisation functions will only work if people have scikit-bio installed as well. |
I started working on new workflow to check if the memo can be build/installed as pip package.
I ran into issues with
scikit-bio
which only worked for when installing it via conda.When installing it with the other dependencies via pip I get an error that looks like this one: scikit-bio/scikit-bio#1671.
Another problem with scikit-bio is that it supports Python up to 3.7, but
memo
requires Python >= 3.8.(so far that didn't seem to create bigger issues though).
I started working on it in #4 .
The text was updated successfully, but these errors were encountered: