Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Added PEP 484 type hints #156

Open
ThatXliner opened this issue Mar 13, 2021 · 0 comments
Open

Suggestion: Added PEP 484 type hints #156

ThatXliner opened this issue Mar 13, 2021 · 0 comments

Comments

@ThatXliner
Copy link

Description

This library needs type hints. I use MyPy, which complain because this library has no type stubs. You can easily make them with

System settings

Error

N/A

Expected behaviour

MyPy won't get angry

Steps to recreate

  • Install MyPy
  • Use MyPy (mypy .) on codebase that imports Halo
  • MyPy complains:
...   # Other errors
foor/bar.py:N: error: Cannot find implementation or library stub for module named 'halo'
foo/bar.py:N: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
...  # Other errors

People to notify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant