Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning sphinx.util.typing.stringify for Sphinx v7.2.6 #178

Closed
huxuan opened this issue Oct 31, 2023 · 7 comments
Closed

Deprecation warning sphinx.util.typing.stringify for Sphinx v7.2.6 #178

huxuan opened this issue Oct 31, 2023 · 7 comments
Assignees
Labels
deprecation New versions may break with existing API usage.
Milestone

Comments

@huxuan
Copy link

huxuan commented Oct 31, 2023

Running Sphinx v7.2.6
/home/huxuan/Code/serious-scaffold-python/.venv/lib/python3.10/site-packages/sphinxcontrib/autodoc_pydantic/directives/autodocumenters.py:21: RemovedInSphinx80Warning: The alias 'sphinx.util.typing.stringify' is deprecated, use 'sphinx.util.typing.stringify_annotation' instead. Check CHANGES for Sphinx API modifications.
  from sphinx.util.typing import get_type_hints, stringify
@mansenfranzen
Copy link
Owner

Thanks for raising the deprecation warning! I will be recognized in the upcoming release.

@mansenfranzen mansenfranzen changed the title Deprecation warining from Sphinx. Deprecation warning sphinx.util.typing.stringify for Sphinx v7.2.6 Dec 25, 2023
@mansenfranzen mansenfranzen self-assigned this Dec 25, 2023
@mansenfranzen mansenfranzen added the deprecation New versions may break with existing API usage. label Dec 25, 2023
@mansenfranzen mansenfranzen added this to the 2.1 milestone Dec 25, 2023
@mansenfranzen
Copy link
Owner

Done via #190

@mansenfranzen
Copy link
Owner

@all-contributors please add @huxuan for bug

Copy link
Contributor

@mansenfranzen

I've put up a pull request to add @huxuan! 🎉

@mansenfranzen
Copy link
Owner

Before merging the related PR, it would be great if you could test the changed behavior. To do so, please install the current dev release in your doc-building-environment via pip install git+https://github.com/mansenfranzen/autodoc_pydantic.git@v2.1.0-a.1 and rebuild your docs.

Please feel free to reopen if any problem remains. I will release the new version upcoming Monday.

@huxuan
Copy link
Author

huxuan commented Mar 14, 2024

Hi @mansenfranzen,

I created a pull request for test: serious-scaffold/ss-python#405, and the preview documentation generated by autodoc_pydantic can be referred here: https://ss-python--405.org.readthedocs.build/en/405/api/settings.html. it looks like everything works smoothly!

More details:

The workflow run for the pull request:
https://github.com/serious-scaffold/ss-python/actions/runs/8281329818

The workflow run for the latest main branch:
https://github.com/serious-scaffold/ss-python/actions/runs/8280763274

You can refer to the ci (3.8), ci (3.9), ci (3.10), ci (3.11), ci (3.12) as test jobs for different Python versions. In each jobs, the Run make dev step shows the installation of the packages including autodoc_pydantic, and the Run CI_PAGES_URL=https://serious-scaffold.github.io/ss-python make doc step show the documentation building process.

With the logs we can confirm that, when new version of autodoc_pydantic is installed the deprecation warning is gone and the whole documentation building process works for different Python versions.

@mansenfranzen
Copy link
Owner

Thanks for your detailed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation New versions may break with existing API usage.
Projects
None yet
Development

No branches or pull requests

2 participants