-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polarized SANS metadata: add user file definition and ability to parse inputs #38524
Labels
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
SANS
Issues and pull requests related to SANS
Milestone
Comments
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 19, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
Covers both the electric and magnetic field inputs. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
The old txt format won't be able to edit the values like the toml parser, but it will return a blank state so that the behaviour of the two parsers is identical. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
Given that the new things we're adding to the user file aren't compatible with older versions of mantid, we're bumping up to TOML V2 so that we can keep being backwards compatible. This is mainly to stop new user files containing this information from being loaded by older versions, making it clear that you need to upgrade to use these new features and toml files. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
Covers both the electric and magnetic field inputs. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
The old txt format won't be able to edit the values like the toml parser, but it will return a blank state so that the behaviour of the two parsers is identical. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
Given that the new things we're adding to the user file aren't compatible with older versions of mantid, we're bumping up to TOML V2 so that we can keep being backwards compatible. This is mainly to stop new user files containing this information from being loaded by older versions, making it clear that you need to upgrade to use these new features and toml files. RE mantidproject#38524
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
cailafinn
added a commit
to cailafinn/mantid
that referenced
this issue
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
SANS
Issues and pull requests related to SANS
Part of #36147. See the design and requirements documents, and the NXcanSAS specification proposal, that are linked on that issue for more details of what needs to be implemented.
To allow polarized SANS metadata to be saved to the NXcanSAS file via the ISIS SANS reduction workflow, we need to support polarized SANS settings in the TOML user file (also referred to as a mask file). Refer to the IDF components and User File Definition sections of the design document for the specific details of the settings we have agreed need to be implemented.
This issue will be limited to extending the user file parser and state object so that we can read in user files with these settings, apply appropriate validation and store the values in the state object for later use. Actually using the values as part of the reduction workflow save step will be implemented under a separate issue.
A couple of considerations for implementation:
The text was updated successfully, but these errors were encountered: