Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional barrier icons - guard rail, railing, wall #450

Open
RudyTheDev opened this issue Nov 30, 2018 · 2 comments
Open

Additional barrier icons - guard rail, railing, wall #450

RudyTheDev opened this issue Nov 30, 2018 · 2 comments

Comments

@RudyTheDev
Copy link

This would add road vehicle guard rail, pedestrian railing and wall icons:

icons

zoom

The main reason I'm making these is for use with iD preset icons for the respective features -- barrier=guard_rail, barrier=fence; fence_type=railing, and barrier=wall (and possibly =city_wall), since they all use the generic barrier icon.

P. S. I also wanted to add hedge and curb/kerb icons, but I don't know how to draw them. Hedges don't really have a defined outline and all my attempts ended up just being a smudge. Kerbs are similarly just a line, so I tried adding a little drainage grate or street lamp, but it just all looks weird.

P. S. S. Instructions say to branch PRs from "From the current development branch - named "v[version-number]-dev"", but I don't see any dev branches.

@bhousel
Copy link
Contributor

bhousel commented Nov 30, 2018

The main reason I'm making these is for use with iD preset icons for the respective features

Awesome, thanks @RudyTheDev 🙇
If you want to get them into iD faster, it's probably best to open the issue over in the Temaki repo instead: https://github.com/bhousel/temaki

Temaki is just like Maki, except that it's a lot more JFDI and includes things that aren't general-purpose enough for Maki, and it only has 15px icons (which makes things a lot easier).

P. S. I also wanted to add hedge and curb/kerb icons, but I don't know how to draw them. Hedges don't really have a defined outline and all my attempts ended up just being a smudge. Kerbs are similarly just a line, so I tried adding a little drainage grate or street lamp, but it just all looks weird.

Icon design is really hard! In general, less is better.

Remember that we don't need to have an icon for every kind of feature. The purpose of the icons is to help mappers understand the map they are editing. So, showing the difference between a guard rail and a kerb is going to be tough, and maybe not necessary. Drawing a hedge sounds really hard too. But if you want to try, go for it (I will never tell someone not to try a thing) 👍

Some more tips:

  • Check out Noun Project for ideas. I always redraw icons rather than reusing the ones there, because the icons on noun project all have different licenses and styles and it's easier to just redraw from scratch.
  • iD also supports Font Awesome now, so you can use any of the free icons that you find there. Here is a ticket describing how to use different icon sets in iD presets.

Another fun iD icon tip:
If you want a list of all the tags used in iD, the Taginfo project has this. Taginfo fetches a file from the iD repo nightly. Many of the tags are used in the field section and would not need icons, but scrolling through the pages, you'll find some stuff in iD that does not have an icon yet, or where the icon isn't very good.

screenshot 2018-11-30 09 56 56

TIL: iD needs a grit bin icon

@RudyTheDev
Copy link
Author

If you want to get them into iD faster, it's probably best to open the issue over in the Temaki repo instead

Here is a ticket describing how to use different icon sets in iD presets.

Yeah, I checked all the icon sources iD uses to see if there were already icons for this. These barrier ones weren't hard to make for the 11px versions, so I went with making them compatible with this project. I'm not very likely to draw many more icons. If these are too specific for Maki, I'll open an issue for Temaki.

we don't need to have an icon for every kind of feature

Blasphemy! >.<

[..] tags used in iD, the Taginfo project has this.

Cool, I didn't know Taginfo had iD-specific filtering and lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants