-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional barrier icons - guard rail, railing, wall #450
Comments
Awesome, thanks @RudyTheDev 🙇 Temaki is just like Maki, except that it's a lot more JFDI and includes things that aren't general-purpose enough for Maki, and it only has 15px icons (which makes things a lot easier).
Icon design is really hard! In general, less is better. Remember that we don't need to have an icon for every kind of feature. The purpose of the icons is to help mappers understand the map they are editing. So, showing the difference between a guard rail and a kerb is going to be tough, and maybe not necessary. Drawing a hedge sounds really hard too. But if you want to try, go for it (I will never tell someone not to try a thing) 👍 Some more tips:
Another fun iD icon tip: TIL: iD needs a grit bin icon |
Yeah, I checked all the icon sources iD uses to see if there were already icons for this. These barrier ones weren't hard to make for the 11px versions, so I went with making them compatible with this project. I'm not very likely to draw many more icons. If these are too specific for Maki, I'll open an issue for Temaki.
Blasphemy! >.<
Cool, I didn't know Taginfo had iD-specific filtering and lists. |
This would add road vehicle guard rail, pedestrian railing and wall icons:
The main reason I'm making these is for use with iD preset icons for the respective features --
barrier=guard_rail
,barrier=fence; fence_type=railing
, andbarrier=wall
(and possibly=city_wall
), since they all use the generic barrier icon.P. S. I also wanted to add hedge and curb/kerb icons, but I don't know how to draw them. Hedges don't really have a defined outline and all my attempts ended up just being a smudge. Kerbs are similarly just a line, so I tried adding a little drainage grate or street lamp, but it just all looks weird.
P. S. S. Instructions say to branch PRs from "From the current development branch - named "v[version-number]-dev"", but I don't see any dev branches.
The text was updated successfully, but these errors were encountered: