Skip to content

Buggy ring classification on GeoJSON multipolygons #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mourner opened this issue Jun 30, 2017 · 2 comments
Closed

Buggy ring classification on GeoJSON multipolygons #4922

mourner opened this issue Jun 30, 2017 · 2 comments
Labels

Comments

@mourner
Copy link
Member

mourner commented Jun 30, 2017

mapbox-gl-js version: 0.38

When displaying complex multipolygons with holes, there seems to be a bug happening somewhere around the ring classification routine that causes severe striping artifacts when triangulating:

image

If I simply filter out all small rings (length < 20), the artifacts are gone. I'm not yet sure the root is ring classification, but it intuitively looks like the culprit. Needs to be investigated further.

@peterqliu if this is indeed a separate bug from earcutting polygons with small self-intersections, perhaps we could fix some of the artifacts seen on the isochrone demo.

@peterqliu
Copy link
Contributor

I'm a bit out of my depth here, but the rendering bugs on the isochrones demo aren't stripes, but failures to fully flex inward, on concave portions of a polygon. Here's the same thing at two slightly different zooms:

Bad:
screen shot 2017-06-30 at 2 51 56 pm

Good:

screen shot 2017-06-30 at 2 52 02 pm

Approximate location for ^: https://www.mapbox.com/bites/00156/#9.21/52.5851/13.3365

@mourner
Copy link
Member Author

mourner commented Aug 1, 2018

I no longer have a test case from the original report, so closing in favor of tracking issues in #7023.

@mourner mourner closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants