Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Best practices for working with external APIs #107

Open
bkowshik opened this issue Mar 17, 2017 · 0 comments
Open

Best practices for working with external APIs #107

bkowshik opened this issue Mar 17, 2017 · 0 comments
Labels

Comments

@bkowshik
Copy link
Contributor

As compare functions use data from external APIs like osm-comments, Wikidata, etc we need a list of best practices that compare functions are designed with.

Capturing from @amishas157 post: #105 (comment)

Though we are assuming that we won't be hitting wikidata API too hard, but just to be 💯 , what we can do is, catch the errors when wikidata API is ratelimited and find out a way for it to report to us. Maybe we can also use: 'result:wikidataApiLimitExceeded: true, the way we do it for escalate and then read it on vandalism side to send us these error. This list the error codes returned by wikidata API. We can catch forratelimited`. If we get such errors from vandalism, we can figure out some other way, so as to not hit wikidata API hard and also be ensured that this comparator has worked the way it is expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants