Common compare function for checking feature names

[bkowshik]

Adding names and name translations happen pretty often on OpenStreetMap. Yay!!! Quite of few compare functions currently flag any edits to features that satisfy a particular criteria. Ex:

• Edited a major lake flags any edits to features in the list of major lakes.
• Edited an osm landmark flags any edits to a custom list of landmarks on OpenStreetMap.
• Edited a name tagflags any edits to feature name.
• Edited an old monument flags any edit to monuments on OpenStreetMap.

For a large majority of cases, the new names or translations added are 👍

• http://osmcha.mapbox.com/47061003/

How about we move the name checks to a common profanity compare function and flag any other kind of edit from the ^ compare functions? The profanity compare function in turn will focus just on identifying problems with values of name:*.

---

cc: @amishas157 @geohacker

[bkowshik]

A couple of compare functions work with feature names. Ex:

• getNameChanged in place_edited.js
• major_name_modification.js

We should 👀 if there are opportunities to merge them into this common compare function.

[bkowshik]

From @nikhilprabhakar's post here: #110 (comment)

case where the user named the feature after the user's name

• https://www.openstreetmap.org/way/470063404

User MattForce could have potentially named the lake after himself as Lake Matt

Should the name compare function do this check as well?

[bkowshik]

Changing the order of words is an interesting scenario. Ex:

• http://osmcha.mapbox.com/47217211/features/way-149714985/

The name of the feature was modified from Воскресенская церковь (Resurrection Church) to Церковь Воскресения Христова (Church of the Resurrection).

[bkowshik]

Minor name modifications can be ignored for a while. Ex:

• https://osmcha.mapbox.com/47212289/features/way-182671143/

The features name was modified from Thun - Hohenštejnský palác to Thun-Hohenštejnský palác, which is a couple of blank spaces was removed.

• https://osmcha.mapbox.com/47211187/features/relation-60015/

Palác Thurn-Taxisů modified to palác Thurn-Taxisů

• https://osmcha.mapbox.com/47200688/features/way-30793888/

The name was modified from St. Joseph Hospital to Saint Joseph Hospital

[bkowshik]

There are times when the case of the name (uppercase / lowercase) does not matter much. We can ignore these for a while. Ex:

• https://osmcha.mapbox.com/47209062/features/way-150442279/

The name was modified from Aldi to ALDI.

[bkowshik]

Thank you for your feedback @bsrinivasa, 😃

[bkowshik]

For the first iteration of this compare function, let's do the following checks:

• If feature has a Wikidata tag, does the feature's name match the name on Wikidata
• Is there any profanity in the feature name
• Was this is a major name change or a minor one using [Levenshtein distance](https://en.wikipedia.org/wiki/Levenshtein_distance

---

cc: @amishas157

[srividyacb]

Everyday a lot of features get names and many features names gets deleted. Found an edit where the feature tag and name string is similar

Examples :

• https://www.openstreetmap.org/node/4766144429
• http://www.openstreetmap.org/node/4017606804

This kind of name changes are 100% incorrect and we need to flag it as part of our compare function. The name combination can look like :

• Feature tag + name string are similar (with some case changes)
• name tag with any of the standard tags

Would like some suggestions on this.

cc @bkowshik @amishas157