Replies: 1 comment
-
There are two options here:
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
The following tests basically fail on fonts drawing:
Take "test-render debug/raster" as an example:
Actual:
Expected:
Diff:
The fonts are drawn by code here:
"https://github.com/maplibre/maplibre-gl-js/blob/main/src/render/draw_debug.ts"
Form history, above code wasn't changed big.
On May of 2022 exact the 2 tests were updated once:
At that time the tests should still passed.
At that time "gl" (headless-gl) package was still at version 5.0.0
I did following tests:
1, I reverted this history change: cfbc39f
Manually replace "gl" to version 5.0.0
Built and run the tests, still fail.
2, Downloaded "dist" folder of "https://github.com/maplibre/maplibre-gl-js/releases/tag/v2.2.0-pre.1".
Which was released on May 12, 2022. Run the tests, still fail.
Since the fonts are rendered using Canvas calls, I think the fonts rendering result's difference is caused by "head-less".
Can I just update the "expected.png" to latest? Or any suggestion for further investigation?
Thanks.
Beta Was this translation helpful? Give feedback.
All reactions