Incorrect MissingClosingTagError/MissingOpeningTagError

[joelhawksley]

Hi folks! I'm working to test Herb/ReActionView against various GitHub projects and just ran into what I believe is an incorrect error:

<% if @with_icon %>
  <div class="icon">
<% end %>
...
<% if @with_icon %>
  </div>
<% end %>

Raises MissingClosingTagError/MissingOpeningTagError, when it should not.

The actual file highlighting this issue is https://github.com/primer/view_components/blob/c1845c65c3d7aaae3abb31f9846279783734974e/app/components/primer/alpha/auto_complete/auto_complete.html.erb, but the sample provided here raises the same errors.

[adam-h]

Running into a similar issue with:

<dialog data-controller="dialog" <% if local_assigns[:permanent] %>data-turbo-permanent<% end %>>

Remove silent ERB tag from HTML attribute name. Silent ERB tags (`<%`) do not output content and should not be used in attribute names.Herb Linter [erb-no-silent-tag-in-attribute-name](https://herb-tools.dev/linter/rules/erb-no-silent-tag-in-attribute-name)

Staying on 0.7.5 for now, as it seems we use similar patterns in a few places

[marcoroth]

Thanks for reporting @joelhawksley and @adam-h! 🙏🏼

I'm not 100% if and how we should support this, but I feel like we should as it's coming up quite a lot. At least we should be able to "warn" people that there are better ways to rewrite/express this.

Related: #83, #84, #398, #399, #490, #701, #779

[marcoroth]

@adam-h the issue you mentioned is slightly different from the original one in this issue. But, I just opened #873 to address yours 🙌🏼