Skip to content

Use UIScrollView's gesture instead of adding a new UIPanGestureRecognizer #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryan1anderson opened this issue Jan 11, 2019 · 6 comments
Assignees
Labels
enhancement improve current feature
Milestone

Comments

@bryan1anderson
Copy link

I am using this library to present several UIViewControllers. Many of them have UIScrollView subviews.

ModalTransitionDelegate.interactiveController.gestureRecognizer is private and this makes it impossible for me to tell my views to prefer their gesture recognizers over the interactive controllers gesture recognizer.

What is your recommended way around this?

@marcosgriselli marcosgriselli added the enhancement improve current feature label Jan 12, 2019
@marcosgriselli marcosgriselli self-assigned this Jan 12, 2019
@marcosgriselli
Copy link
Owner

Hi Bryan, good point. I never had the time to actually implement transitions with UIScrollView easily. Let me take a short look at it in the upcoming days and I'll try to come up with a solution. I wish I had a temporal solution you could implement to work around it but it will require editing the Pan enum and all of the related code. I'll keep you updated on this.

@sevgjan
Copy link

sevgjan commented Jan 13, 2019

@bryan1anderson were you able to implement the library with UIScrollView because I have a very strange top inset which I fix it on opening, but dismissal is somehow jumping and not good when returning on UICollectionViewCell when dismissing DetailViewController with button.

@marcosgriselli first, thanks for your great work.
Do you have any example on how can this transition be used with UIScrollView inside of CardDetail? Something similar to AppStore?

@marcosgriselli marcosgriselli changed the title Cancel gestures for interactive transitions Use UIScrollView's gesture instead of adding a new UIPanGestureRecognizer Jan 13, 2019
@marcosgriselli marcosgriselli added this to the 0.6.0 milestone Jan 13, 2019
@marcosgriselli
Copy link
Owner

@sevgjan I'll be working on this shortly. I'll keep you guys posted.

@sevgjan
Copy link

sevgjan commented Apr 30, 2019

@marcosgriselli hey man, sorry to bother, any news on this issue? did we miss something?

@marcosgriselli
Copy link
Owner

Hey @sevgjan no worries. I'm gonna be totally honest I haven't had the time to work on this. I took a look at it when the issue was created and realized it wasn't as easy as applying a hack so I can't give an estimate of when this will be fixed/supported. Sorry for the inconvenience.

@sevgjan
Copy link

sevgjan commented May 2, 2019

No problem @marcosgriselli , just wanted to check if there's any news on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve current feature
Projects
None yet
Development

No branches or pull requests

3 participants