hotfix: fixed issue where aliases could be None in group

Author: marcusfrdk

click_with_aliasing/_aliased_group.py

@@ -26,10 +26,16 @@ def add_command(
         Raises:
             ValueError: If the command name is already taken.
         """
-        aliases = getattr(cmd, "aliases", [])
+        aliases = getattr(cmd, "aliases", None)
+        if aliases is None:
+            aliases = []
+        elif not isinstance(aliases, (list, tuple)):
+            aliases = [aliases] if isinstance(aliases, str) else []
+
         super().add_command(cmd, name)
         for alias in aliases:
-            super().add_command(cmd, alias)
+            if isinstance(alias, str) and alias.strip():
+                super().add_command(cmd, alias)
 
     def format_commands(
         self, ctx: click.Context, formatter: click.HelpFormatter
@@ -48,9 +54,18 @@ def format_commands(
         commands = {}
         for name, cmd in self.commands.items():
             if name == cmd.name:
-                aliases = getattr(cmd, "aliases", [])
-                if aliases:
-                    name = f"{name} ({', '.join(aliases)})"
+                aliases = getattr(cmd, "aliases", None)
+                if aliases is None:
+                    aliases = []
+                elif not isinstance(aliases, (list, tuple)):
+                    aliases = [aliases] if isinstance(aliases, str) else []
+
+                valid_aliases = [
+                    a for a in aliases if isinstance(a, str) and a.strip()
+                ]
+
+                if valid_aliases:
+                    name = f"{name} ({', '.join(valid_aliases)})"
                 commands[name] = cmd
 
         rows = [

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "click_with_aliasing"
-version = "1.1.0"
+version = "1.1.1"
 description = "A library that allows you to add aliases to your Click group and commands."
 authors = [
     { name = "Marcus Fredriksson", email = "marcus@marcusfredriksson.com" },

tests/test_group.py

@@ -63,3 +63,17 @@ def test_async_group_help(self, runner: CliRunner):
         result = runner.invoke(async_group, ["--help"])
         assert result.exit_code == 0
         assert "async_cmd" in result.output
+
+
+def test_add_regular_click_command_to_aliased_group():
+    """Test that regular Click commands can be added to AliasedGroup."""
+
+    @group(name="test_group")
+    def test_grp():
+        pass
+
+    @click.command()
+    def regular_cmd():
+        """A regular Click command."""
+
+    test_grp.add_command(regular_cmd)