Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to publish a package with empty version to the registry #246

Open
2 tasks done
kubkon opened this issue Feb 13, 2025 · 6 comments · Fixed by #247
Open
2 tasks done

It is possible to publish a package with empty version to the registry #246

kubkon opened this issue Feb 13, 2025 · 6 comments · Fixed by #247
Assignees
Labels
backend bug Something isn't working

Comments

@kubkon
Copy link
Contributor

kubkon commented Feb 13, 2025

I have checked the following:

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked that the bug is reproducible with the latest version of Soldeer.

Soldeer Version

soldeer 0.5.2

What Happened?

We use automated pushing of our contracts to the soldeer registry and somehow a bug crept in that erroneously pushed our package with missing version:

Image

I have since repro'ed the issue using a dummy test project and managed to push the project with an empty version:

Image

Expected Behavior

$ forge init
$ soldeer push my-project~ --dry-run
...
error during publishing: package version cannot be empty

(Should return an error that version cannot be empty.)

Reproduction Steps

$ forge init
$ soldeer push my-project~ --dry-run
...
Done!

(Should never succeed.)

Configuration

@kubkon kubkon added the bug Something isn't working label Feb 13, 2025
@mario-eth
Copy link
Owner

this is interesting, will double check on the backend as well, at least the backend should have caught it. weird. thanks for the fix, will review

@mario-eth
Copy link
Owner

I'm reopening this so i can keep track to solve on the backend

@mario-eth mario-eth reopened this Feb 13, 2025
@mario-eth mario-eth self-assigned this Feb 13, 2025
@kubkon
Copy link
Contributor Author

kubkon commented Feb 14, 2025

@mario-eth would it be possible for you and any other maintainer with access to the backend to yank an invalid published (empty) version? In particular, at vlayer we are currently blocked by this in vlayer package. If you list more versions you will see this bug manifested itself between 0.1.0-nightly-20250127-334f0a0 and 0.1.0-nightly-20250127-5ee6ca8. Any help on this would greatly be appreciated! Thanks!

@mario-eth
Copy link
Owner

you mean to delete this empty version?

Image

@kubkon
Copy link
Contributor Author

kubkon commented Feb 14, 2025

Yep, exactly right!

@mario-eth
Copy link
Owner

mario-eth commented Feb 14, 2025

@mario-eth would it be possible for you and any other maintainer with access to the backend to yank an invalid published (empty) version? In particular, at vlayer we are currently blocked by this in vlayer package. If you list more versions you will see this bug manifested itself between 0.1.0-nightly-20250127-334f0a0 and 0.1.0-nightly-20250127-5ee6ca8. Any help on this would greatly be appreciated! Thanks!

solved, we run the integrity checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants