Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Updating passwords app is very slow on an instance with lots of users #696

Open
5 of 6 tasks
akhil1508 opened this issue Jan 6, 2025 · 0 comments
Open
5 of 6 tasks
Labels
bug Something in the app is not working as expected

Comments

@akhil1508
Copy link

akhil1508 commented Jan 6, 2025

⚠️ This issue respects the following points: ⚠️

  • This is a single bug, not a question or a configuration/webserver/proxy issue.
  • This is not a bug in the browser extension or another client.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server and the Passwords App is up to date. See Nextcloud Apps.
  • There are no warnings and errors reported in the Passwords App settings in the admin area
  • The following apps are not installed: Rainloop

Server Information

{
    "version": {
        "server": "28.0.9.6",
        "app": "2023.12.32",
        "lsr": false,
        "php": "8.2.23",
        "cronPhp": "8.2.23"
    },
    "environment": {
        "os": "Linux",
        "architecture": "x86_64",
        "bits": 64,
        "database": "mysql",
        "cron": "cron",
        "proxy": false,
        "sslProxy": true,
        "subdirectory": false
    },
    "services": {
        "images": "imagick",
        "favicons": "default",
        "previews": "default",
        "security": "hibp",
        "words": "auto",
        "previewApi": false,
        "faviconApi": false
    },
    "status": {
        "autoBackupRestored": false
    },
    "settings": {
        "channel": "stable",
        "nightlies": false,
        "handbook": false,
        "performance": 5
    },
    "encryption": {
        "sse": {
            "SSEv1r1": false,
            "SSEv1r2": true,
            "SSEv2r1": false,
            "SSEv3r1": false,
            "none": false,
            "default": "SSEv1r2"
        },
        "cse": {
            "CSEv1r1": false,
            "none": true,
            "default": "none"
        }
    }
}

Client Information

Browser and Version:
Client OS and Version:

Bug description

  • Updating the passwords app takes a very long time
  • More specifically the repair steps take a very long time:
- tag revisions
- folder revisions
- password revisions
- tag models
- folder models
- password models
- password tag relation repair
- share repair
  • Of these the password models repair step is what takes the longest time and at the end there is a message saying Fixed 0 password models

  • I'm yet to see this repair step fix something but each time it takes a very long time to update passwords app because of this🤔

  • Maybe making these model repair steps into steps that just add background jobs to the queue would be enough? So that the app is updated quickly enough but the repair steps are not skipped?

Steps to reproduce

  1. occ app:disable passwords
  2. occ app:update passwords
  3. occ app:enable passwords

Expected behavior

  • Quick update process for the passwords app
  • Less downtime for the users

Nextcloud Logs

No response

Browser Logs

No response

@akhil1508 akhil1508 added the bug Something in the app is not working as expected label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something in the app is not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant