Skip to content

banter.crucible.Crucible use of staticmethod makes overriding hard #3

@spookylukey

Description

@spookylukey

Is there a reason that the Crucible class uses staticmethod everywhere? If you change to a normal method, then a subclass can override these methods. Because they are called like Crucible.get_create_review_payload, instead of self.get_create_review_payload, subclassing to modify won't work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions