Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.4+ / Django 1.8+ support #93

Open
eb-emilio opened this issue Aug 14, 2020 · 5 comments
Open

Python 3.4+ / Django 1.8+ support #93

eb-emilio opened this issue Aug 14, 2020 · 5 comments

Comments

@eb-emilio
Copy link
Contributor

Is there any plan to run travis on newer versions of Python and Django?

python:
  - "2.7"
  - "3.4"

env:
  - DJANGO_VERSION=1.7.8
  - DJANGO_VERSION=1.8.1

Code is not Python 3.7 compatible at least because it is calling unicode which is not available.

I volunteer to add this support in a pull request if you are interested.

@markfinger
Copy link
Owner

Sure, sounds good 👍

I think the code should function in both py2 and py3 as the unicode call is wrapped in __unicode__ which would only get called on py2. That being said maybe there's something in 3.7 that I'm not aware of 🤷

@markfinger
Copy link
Owner

Closed by #94

@markfinger
Copy link
Owner

Looks like there are some compatibility issues: #94.

We'll need to figure out what we're aiming to support.

Python

I'm happy to drop py2 support. Internally we've got a few projects still running on it, but they're largely in a slow-maintenance / legacy mode.

Django

From https://www.djangoproject.com/download/, it looks Django 3.x and Django 2.2 are still supported. Recommend we consolidate on those.

@markfinger
Copy link
Owner

@eb-emilio any qualms if we switch the travis config to something like

python:
  - "3.8"

env:
  - DJANGO_VERSION=2.2.16
  - DJANGO_VERSION=3.1.1

@eb-emilio
Copy link
Contributor Author

@markfinger yes, that makes sense. Sorry about that. We are on the same boat on legacy apps but it sounds good to stop testing Python 2.x and Django 1.x since they don't have support anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants