deprecate Player.Velocity & Player.PreviousFramePosition

markus-wa · markus-wa · commit b8fd00096ff0 · 2024-09-04T19:20:33.000+01:00
diff --git a/pkg/demoinfocs/common/player.go b/pkg/demoinfocs/common/player.go
@@ -33,7 +33,7 @@ type Player struct {
 	IsPlanting            bool
 	IsReloading           bool
 	IsUnknown             bool      // Used to identify unknown/broken players. see https://github.com/markus-wa/demoinfocs-golang/issues/162
-	PreviousFramePosition r3.Vector // CS2 only, used to compute velocity as it's not networked in CS2 demos
+	PreviousFramePosition r3.Vector // Deprecated: may be removed in v5 due to performance concerns, track this yourself.
 }
 
 func (p *Player) PlayerPawnEntity() st.Entity {
@@ -537,6 +537,7 @@ func (p *Player) PositionEyes() r3.Vector {
 }
 
 // Velocity returns the player's velocity.
+// Deprecated: will be removed due to performance concerns, you will need to track this yourself.
 func (p *Player) Velocity() r3.Vector {
 	if p.demoInfoProvider.IsSource2() {
 		t := 64.0

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ type Player struct {`
`33`	`33`	`IsPlanting bool`
`34`	`34`	`IsReloading bool`
`35`	`35`	`IsUnknown bool // Used to identify unknown/broken players. see https://github.com/markus-wa/demoinfocs-golang/issues/162`
`36`		`- PreviousFramePosition r3.Vector // CS2 only, used to compute velocity as it's not networked in CS2 demos`
	`36`	`+ PreviousFramePosition r3.Vector // Deprecated: may be removed in v5 due to performance concerns, track this yourself.`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`func (p *Player) PlayerPawnEntity() st.Entity {`
`@@ -537,6 +537,7 @@ func (p *Player) PositionEyes() r3.Vector {`
`537`	`537`	`}`
`538`	`538`
`539`	`539`	`// Velocity returns the player's velocity.`
	`540`	`+// Deprecated: will be removed due to performance concerns, you will need to track this yourself.`
`540`	`541`	`func (p *Player) Velocity() r3.Vector {`
`541`	`542`	`if p.demoInfoProvider.IsSource2() {`
`542`	`543`	`t := 64.0`