Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapsed menu in B&W theme #10542

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix collapsed menu in B&W theme #10542

merged 2 commits into from
Feb 25, 2025

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Feb 21, 2025

Problem

When using the B&W theme, the collapsed menu looks off

Capture d’écran 2025-02-21 à 21 43 36

Solution

Fix the theme.

Capture d’écran 2025-02-21 à 21 43 59

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When closed, expanded 2nd level menu items are not aligned horizontally with 1st level items.

Is this intended?

Default theme:

Screenshot_20250224_143904

B&W theme:

Screenshot_20250224_144019

@fzaninotto
Copy link
Member Author

This isn't a problem with B&W theme, but with the demo, which hardcodes the padding of collapsed submenu. I had to include a component-specific override to fix it.

@slax57 slax57 added this to the 5.6.2 milestone Feb 25, 2025
@slax57 slax57 merged commit c3d60d4 into master Feb 25, 2025
16 checks passed
@slax57 slax57 deleted the bw-menu-closed branch February 25, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants