Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate about Node.js single executable applications #568

Closed
yhatt opened this issue Feb 14, 2024 · 2 comments · Fixed by #591
Closed

Investigate about Node.js single executable applications #568

yhatt opened this issue Feb 14, 2024 · 2 comments · Fixed by #591

Comments

@yhatt
Copy link
Member

yhatt commented Feb 14, 2024

Node.js v19.7 and later include experimental support for single executable applications.

The standalone binaries of Marp CLI are currently produced by Vercel's pkg. However, due to the discontinuation of the pkg project in favor of Node.js's efforts, we must consider migrating.

pkg has been deprecated with 5.8.1 as the last release. There are a number of successful forked versions of pkg already with various feature additions. Further, we’re excited about Node.js 21’s support for single executable applications. Thank you for the support and contributions over the years. The repository will remain open and archived.

https://github.com/vercel/pkg

pkg is still working but using compiled binary would be dangerous, due to the elevation of privilege vulnerability. (CVE-2024-24828)

@Aurosish07
Copy link

Aurosish07 commented Jun 20, 2024

but pkg does not work with latest version of node.js and i am facing problems with the node.js inbuilt single executable application feature plz help if anyone know the correct way , i got stuck when it told to remove es module to common js

@yhatt
Copy link
Member Author

yhatt commented Aug 31, 2024

Node.js SEA is still primitive, and it would take much longer time to make stable use. Meanwhile, we should switch pkg into well-maintained community fork @yao-pkg/pkg.

I could not find out a specific patch for the elevation of privilege vulnerability CVE-2024-24828, so I cannot say for certain that the forked pkg ensures the safety. However, yao-pkg/pkg#55 looks a good patch for known CVE. (yao-pkg/pkg#51 (comment))

@yhatt yhatt linked a pull request Sep 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants