#135 Bavarian Holidays Assumption is conditional

Author: martinjw

src/PublicHoliday/GermanPublicHoliday.cs

@@ -259,13 +259,23 @@ public static DateTime Assumption(int year)
             return new DateTime(year, 8, 15);
         }
 
+        private bool? _hasAssumption;
         /// <summary>
         /// Whether this state observes Mariä Himmelfahrt.
         /// </summary>
         /// <value>
         /// <c>true</c> if this state observes Mariä Himmelfahrt; otherwise, <c>false</c>.
         /// </value>
-        public bool HasAssumption => States.SL == State  || States.BY == State;
+        public bool HasAssumption
+        {
+            get
+            {
+                //if they set manually, override the state default
+                if(_hasAssumption.HasValue) return _hasAssumption.Value;
+                return States.SL == State || States.BY == State;
+            }
+            set => _hasAssumption = value;
+        }
 
         /// <summary>
         /// Kindertag - World Children's Day

src/PublicHoliday/Properties/AssemblyInfo.cs

@@ -32,8 +32,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.39.0.0")]
-[assembly: AssemblyFileVersion("2.39.0.0")]
+[assembly: AssemblyVersion("2.40.0.0")]
+[assembly: AssemblyFileVersion("2.40.0.0")]
 
 // Visibility of project of test
 [assembly: InternalsVisibleTo("PublicHolidayTests")]

src/PublicHoliday/PublicHoliday.csproj

@@ -54,7 +54,8 @@
 2.36.0: #116 Fixed Japanese Vernal and Autumnal Equinox days (thanks @Makaopior )
 2.37.0: #120 Add Brazil holidays (thanks @rsegecin ), Netherlands add Good Friday (thanks @wdnijdam  )
 2.38.0: #122 Update Switzerland Holiday with Cantons (thanks @tossnet), Add NYSE holidays  (thanks @stephenherrick )
-2.39.0: #125 Fix Turkey Ramadan and FeastOfSacrifices holidays (thanks @hasankaplan-github), #128 Update Switzerland Holiday (thanks @tossnet),; #131 Update France holiday with overseas territories (thanks @tossnet); #132 Add Portugal Holiday (thanks @greybird); #133 South Africa 2024 election day (thanks @FifoTheHein)</PackageReleaseNotes>
+2.39.0: #125 Fix Turkey Ramadan and FeastOfSacrifices holidays (thanks @hasankaplan-github), #128 Update Switzerland Holiday (thanks @tossnet),; #131 Update France holiday with overseas territories (thanks @tossnet); #132 Add Portugal Holiday (thanks @greybird); #133 South Africa 2024 election day (thanks @FifoTheHein)
+2.40.0: #135 Bavarian Assumption date is conditional</PackageReleaseNotes>
     <PackageProjectUrl>https://github.com/martinjw/Holiday</PackageProjectUrl>
     <PackageLicenseUrl></PackageLicenseUrl>
     <Description>Calculate national public holidays for countries including US, UK, France, Belgium, Germany, Australia, Canada and many others for any year</Description>
@@ -69,7 +70,7 @@
     <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
-    <Version>2.39.0</Version>
+    <Version>2.40.0</Version>
 
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>

tests/PublicHolidayTests/PublicHolidayTests.csproj

@@ -21,8 +21,8 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.4.3" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.4.3" />
+    <PackageReference Include="MSTest.TestAdapter" Version="3.5.1" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.5.1" />
   </ItemGroup>
 
   <ItemGroup>

tests/PublicHolidayTests/TestGermanyPublicHoliday.cs

@@ -157,5 +157,23 @@ public void TestBrandenbugSundayHolidays()
             // Pentecost sunday
             Assert.IsTrue(calendar.PublicHolidays(2023).Contains(new DateTime(2023, 5, 28)));
         }
+
+        [TestMethod]
+        public void TestBavariaAssumption()
+        {
+            var assumption = GermanPublicHoliday.Assumption(2024);
+            //assumption is 15/08/2024
+            var calendar = new GermanPublicHoliday { State = GermanPublicHoliday.States.BY };
+            var isHoliday = calendar.IsPublicHoliday(assumption); //true
+            Assert.IsTrue(isHoliday);
+
+            var hasAssumption = calendar.HasAssumption; //true
+            Assert.IsTrue(hasAssumption);
+            //override the default - it should be false
+            calendar.HasAssumption = false;
+            isHoliday = calendar.IsPublicHoliday(assumption); //false
+            Assert.IsFalse(isHoliday);
+
+        }
     }
 }