Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Selectable' and 'Unselectable' row for DataTable is not visually distinguishable enough #2149

Closed
LinQiaoPorco opened this issue Sep 13, 2024 · 2 comments · Fixed by #2150
Closed
Labels
Milestone

Comments

@LinQiaoPorco
Copy link

Is your feature request related to a problem? Please describe.
image
Users can only see the grey color is a little lighter in 'Unselectable' row than normal rows

Describe the solution you'd like
image.
We can have a better comparison between rows Selectable and Unselectable

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@capdiem
Copy link
Contributor

capdiem commented Sep 13, 2024

@LinQiaoPorco Thank you for your feedback! I completely agree with your suggestion and plan to implement it in the upcoming v1.8.0 release.

@capdiem
Copy link
Contributor

capdiem commented Sep 14, 2024

@LinQiaoPorco After careful consideration, I believe it's best not to change too many default styles. Instead, I have slightly adjusted the disabled color and added a class name m-data-table__disabled. If you're not satisfied with the new disabled color, you can customize the row styles based on this new class name.

.theme--light.m-data-table tr.m-data-table__disabled {
  color: rgba(0, 0, 0, .24);
}

.theme--dark.m-data-table tr.m-data-table__disabled {
  color: rgba(255, 255, 255, .42);
}

This will be released in v1.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants