libvmaf: Use model='path=...' instead of model_path=... #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on windows, it doesn't work, with or without |
|
Hm.. Might need different escaping than the others. Sorry but someone else will have to do a PR then unless you dont mind waiting a few weeks, as I said only have a laptop with linux atm |
damster101
approved these changes
Sep 23, 2024
shssoichiro
force-pushed
the
update-libvmaf-model-parameter
branch
from
a526362
to
9e767a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #856.
Closes #821.
I only have a slow laptop at the moment. Can someone else please test this change?
This is a quick bandaid over
--vmaf-pathnot working in FFmpeg 7. It probably can't handle paths with a', but I'm not sure.See #659 and #724 and #806 for proper solutions instead of this.