From ea1134a1a77c032f8b8c6c749e670fca90d8cd89 Mon Sep 17 00:00:00 2001
From: Valentin Degenne <vdegenne@gmail.com>
Date: Wed, 27 Nov 2024 23:02:39 +0100
Subject: [PATCH] fix(iconbutton): href will respond to touch target

---
 iconbutton/internal/_shared.scss   | 2 ++
 iconbutton/internal/icon-button.ts | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/iconbutton/internal/_shared.scss b/iconbutton/internal/_shared.scss
index b1275f5ba5..d668c75e62 100644
--- a/iconbutton/internal/_shared.scss
+++ b/iconbutton/internal/_shared.scss
@@ -92,8 +92,10 @@
   }
 
   .link {
+    display: grid;
     height: 100%;
     outline: none;
+    place-items: center;
     position: absolute;
     width: 100%;
   }
diff --git a/iconbutton/internal/icon-button.ts b/iconbutton/internal/icon-button.ts
index a74f70c3c2..5dc3fff2d1 100644
--- a/iconbutton/internal/icon-button.ts
+++ b/iconbutton/internal/icon-button.ts
@@ -179,8 +179,7 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
         ${this.renderRipple()}
         ${!this.selected ? this.renderIcon() : nothing}
         ${this.selected ? this.renderSelectedIcon() : nothing}
-        ${this.renderTouchTarget()}
-        ${this.href && this.renderLink()}
+        ${this.href ? this.renderLink() : this.renderTouchTarget()}
   </${tag}>`;
   }
 
@@ -193,7 +192,9 @@ export class IconButton extends iconButtonBaseClass implements FormSubmitter {
         id="link"
         href="${this.href}"
         target="${this.target || nothing}"
-        aria-label="${ariaLabel || nothing}"></a>
+        aria-label="${ariaLabel || nothing}">
+        ${this.renderTouchTarget()}
+      </a>
     `;
   }