perhaps use a helper function instead?

Author: DanielYang59

src/pymatgen/core/sites.py

@@ -13,6 +13,7 @@
 from pymatgen.core.lattice import Lattice
 from pymatgen.core.periodic_table import DummySpecies, Element, Species, get_el_sp
 from pymatgen.util.coord import pbc_diff
+from pymatgen.util.misc import is_np_dict_equal
 
 if TYPE_CHECKING:
     from typing import Any
@@ -96,18 +97,10 @@ def __eq__(self, other: object) -> bool:
         if not isinstance(other, type(self)):
             return NotImplemented
 
-        # Some properties could be np.array, and in these cases
-        # using "==" for dict equality check would fail
-        try:
-            np.testing.assert_equal(self.properties, other.properties)
-            prop_equal = True
-        except AssertionError:
-            prop_equal = False
-
         return (
             self.species == other.species
             and np.allclose(self.coords, other.coords, atol=type(self).position_atol)
-            and prop_equal
+            and is_np_dict_equal(self.properties, other.properties)
         )
 
     def __hash__(self) -> int:
@@ -368,17 +361,11 @@ def __eq__(self, other: object) -> bool:
         if not isinstance(other, type(self)):
             return NotImplemented
 
-        try:
-            np.testing.assert_equal(self.properties, other.properties)
-            prop_equal = True
-        except AssertionError:
-            prop_equal = False
-
         return (
             self.species == other.species
             and self.lattice == other.lattice
             and np.allclose(self.coords, other.coords, atol=Site.position_atol)
-            and prop_equal
+            and is_np_dict_equal(self.properties, other.properties)
         )
 
     def __repr__(self) -> str:

src/pymatgen/util/misc.py

@@ -0,0 +1,23 @@
+"""The util package implements various utilities that are commonly used by various
+packages.
+"""
+
+from __future__ import annotations
+
+import numpy as np
+
+
+def is_np_dict_equal(dict1, dict2, /) -> bool:
+    """Compare two dict whose value could be np arrays.
+
+    Args:
+        dict1 (dict): The first dict.
+        dict2 (dict): The second dict.
+
+    Returns:
+        bool: Whether these two dicts are equal.
+    """
+    if dict1.keys() != dict2.keys():
+        return False
+
+    return all(np.array_equal(dict1[key], dict2[key]) for key in dict1)