feat: add reuseExistingPanels #1033
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original experimental work for persistent unused panels (always keep-alive) Adds reuseExistingPanels option to fromJSON() method to preserve existing panel instances Rebased from commit 97e8a95 (Nov 30, 2024) onto current master (v4.11.0) to resolve conflicts and integrate with latest codebase changes. Key changes during rebase: - Combined MoveGroupOrPanelOptions to include both skipSetActive and keepEmptyGroups options - Updated to use movingLock() method matching current upstream conventions - Removed readonly modifiers from constraint properties to support updateFromStateModel - Preserved isDestinationGroupEmpty check logic from master - Integrated new test cases for reuseExistingPanels functionality Co-authored-by: David Tsai <david.tsai@skydio.com> Original-Author: mathuo <6710312+mathuo@users.noreply.github.com> Related-Branch: upstream/718-persistent-unused-panels-always-keep-alive
david-tsai-skydio
force-pushed
the
feat/reuse-existing-panels
branch
from
7161278 to
e3cda20
Compare
Author
Explicitly call contentContainer.openPanel() in doSetActivePanel to ensure panels are correctly attached to the DOM when they become active, fixing issues where panels moved from popout windows would not render.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 45ae882:
|
Author
|
@mathuo - Thanks for taking a look at this, I saw that you got the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues experimental work from @mathuo for persistent unused panels (always keep-alive). Adds
reuseExistingPanelsoption tofromJSON()method to preserve existing panel instances.Rebased from commit 97e8a95 (Nov 30, 2024) onto current master (v4.11.0) to resolve conflicts and integrate with latest codebase changes.
@mathuo - I had to replace
runWithSuppressedEventsin favor ofmovingLockusage based on what I saw, it looks like that got renamed.Related: #778
cc: @crubier