Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_room_keys_received_on_notification_client_trigger_redecryption test is flaky #4459

Closed
richvdh opened this issue Jan 2, 2025 · 4 comments · Fixed by #4468
Closed

test_room_keys_received_on_notification_client_trigger_redecryption test is flaky #4459

richvdh opened this issue Jan 2, 2025 · 4 comments · Fixed by #4468
Assignees
Labels
intermittent-failure Tests that are flaky aka don't fail all the time.

Comments

@richvdh
Copy link
Member

richvdh commented Jan 2, 2025

This test was introduced in 0ca35d6 (#4348), but it looks like it's flaky: https://github.com/matrix-org/matrix-rust-sdk/actions/runs/12463937263/job/34787181014

It looks like Alice didn't actually send the to-device message to Bob. Presumably she hadn't yet received the memo that he had joined.

@bnjbvr
Copy link
Member

bnjbvr commented Jan 6, 2025

Another failure, apparently a different failure mode: the notification client fails to decrypt the event:

https://github.com/matrix-org/matrix-rust-sdk/actions/runs/12632299265/job/35195713771

@bnjbvr bnjbvr added the intermittent-failure Tests that are flaky aka don't fail all the time. label Jan 6, 2025
@bnjbvr
Copy link
Member

bnjbvr commented Jan 6, 2025

Another instance here: https://github.com/matrix-org/matrix-rust-sdk/actions/runs/12634558366/job/35202551369.
Same line and diagnostic as my previous comment.

@poljar
Copy link
Contributor

poljar commented Jan 7, 2025

This should be fixed by #4468.

@bnjbvr
Copy link
Member

bnjbvr commented Jan 7, 2025

Thank you Damir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermittent-failure Tests that are flaky aka don't fail all the time.
Projects
None yet
3 participants