Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset_identity edge case when the user has several backup version server side #4502

Open
BillCarsonFr opened this issue Jan 10, 2025 · 2 comments

Comments

@BillCarsonFr
Copy link
Member

As per code the reset flow should:

/// Completely reset the current user's crypto identity.
/// This method will go through the following steps:
///
/// 1. Disable backing up room keys and delete the active backup
/// 2. Disable recovery and delete secret storage
/// 3. Go through the cross-signing key reset flow
/// 4. Finally, re-enable key backups (only if they were already enabled)

The problem is that if there are several version published on the server, this code will only delete the "current" one.

Then step 4. will fail with BackupExistsOnServer

On the js-sdk there is some code to delete all backup versions

@BillCarsonFr
Copy link
Member Author

step to reproduce:

  • use a client that allows to add a new backup without deleting the previous one.
  • Try to reset identity from EX => reset will fail

@poljar
Copy link
Contributor

poljar commented Jan 10, 2025

This is somewhat related to: #4190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants