Skip to content

Commit 083e6ef

Browse files
authored
Fix npm publishing being broken in CI (#1765)
* Fix `v` tag_name prefix sneaking into npm version * Fix `yarn version` failing in CI due to no git global ident name * Add changelog * Rename 1765.misc to 1765.clarification
1 parent bd122b3 commit 083e6ef

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/release.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ jobs:
2626
- name: 🔨 Install dependencies
2727
run: "yarn install --frozen-lockfile"
2828

29+
# We bump the package.json version to git, we just need it for publish to do the right thing
2930
- name: 🎖 Bump package.json version
30-
run: "yarn version --new-version $VERSION"
31+
run: "yarn version --new-version ${VERSION#v} --no-git-tag-version"
3132
env:
3233
VERSION: ${{ github.event.release.tag_name }}.0
3334

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix npm release script for `@matrix-org/spec`.

0 commit comments

Comments
 (0)