Skip to content

Commit e94a19c

Browse files
committed
Updates for python version of SC/4.1
1 parent 1b1a5e4 commit e94a19c

File tree

3 files changed

+11
-24
lines changed

3 files changed

+11
-24
lines changed

support/chip-testing/test/core/SC.test.ts

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,6 @@ describe("SC", () => {
1919
before(async () => {
2020
await chip.clearMdns();
2121

22-
const sc41 = chip.testFor("SC/4.1");
23-
await sc41.edit(
24-
edit.sed(
25-
// We can pass values to YAML tests using e.g. .args("--", "deviceType", 257)... But AFAICT there is no
26-
// support for converting this value to an integer, even though the config schema specifies "int16u"
27-
// explicitly. So, the test then fails because 257 !== "257". Instead we just rewrite the test
28-
// definition
29-
"s/defaultValue: 65535/defaultValue: 257/",
30-
31-
// We do not like ridiculously long waits; reduce commissioning timeout. Unfortunately test framework
32-
// is slow so we can't reduce to a reasonable level but 10s is still way better than 3m.
33-
"s/value: 180/value: 10/",
34-
35-
// Also reduce the test delay that waits for timeout
36-
"s/value: 180000/value: 10000/",
37-
),
38-
);
39-
4022
const sc71 = chip.testFor("SC/7.1");
4123
await sc71.edit(
4224
edit.sed(
@@ -53,14 +35,17 @@ describe("SC", () => {
5335

5436
chip("SC/*").exclude(
5537
// These require additional configuration below
56-
"SC/4.1",
38+
"SC/4.1/*",
5739
"SC/7.1",
5840
);
5941

60-
// SC/4.1 needs MDNS cleared
61-
chip("SC/4.1").beforeStart(async () => {
62-
await chip.clearMdns();
63-
});
42+
// SC/4.1 needs MDNS cleared. run1 has the wrong manual code; run2 has a pairing code that works. Not sure what's
43+
// up with that. run3 is LIT ICD so not relevant for us
44+
[chip("SC/4.1/run1").args("--manual-code", "34970112332"), chip("SC/4.1/run2")].forEach(builder =>
45+
builder.beforeStart(async () => {
46+
await chip.clearMdns();
47+
}),
48+
);
6449

6550
// 7.1 must start factory fresh
6651
chip("SC/7.1").uncommissioned();

support/chip/sha.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
94d3bbb9916d190ca2d8c02bf911014dc407fb44
1+
bd2f719a6f5bb0fb0d591b633b07eedc96208eb2

support/chip/support/generate-test-descriptor

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ def load_python():
179179
try:
180180
importlib.import_module(name)
181181
except ModuleNotFoundError as e:
182+
sys.stderr.write(f"Error in {path}: {e}\n")
183+
182184
# Skip files with whitelisted errors. Do not skip all errors or build problems may go unnoticed
183185
if "No module named 'matter.webrtc'" in str(e):
184186
# We neither test nor install webrtc support. Test does not fail gracefully

0 commit comments

Comments
 (0)