Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ember-decorators package's import statements #54

Open
axyxnz opened this issue Jan 28, 2019 · 6 comments
Open

Support ember-decorators package's import statements #54

axyxnz opened this issue Jan 28, 2019 · 6 comments

Comments

@axyxnz
Copy link

axyxnz commented Jan 28, 2019

Hey,

As Ember marketing team is generating buzz around Ember Octane Edition, many users are trying out Ember's new features. It would be awesome to allow users autocomplete ember-decorators's import statements to make user's experience better.

Ember Decorators API Documentation:
https://ember-decorators.github.io/ember-decorators/

Module Import File
component import { ... } from '@ember-decorators/component' import-ember-decorators-component.cson
controller import { ... } from '@ember-decorators/controller' import-ember-decorators-controller.cson
data import { ... } from '@ember-decorators/data' import-ember-decorators-data.cson
object import { ... } from '@ember-decorators/object' import-ember-decorators-object.cson
object/computed import { ... } from '@ember-decorators/object/computed' import-ember-decorators-object/-omputed.cson
service import { ... } from '@ember-decorators/service' import-ember-decorators-service.cson
  • All ember-decorators import statements will have imdec prefix.
  • All ember-decorators import statements will be distinguish by #EDAE49 color. See Preview

i.e.

snippets/import-ember-decorators-object.cson

'Ember.object.computed':
  'prefix': 'imdeccomputed',
  'leftLabelHTML': '<span style="color:#EDAE49">Ember Decorators module</span>',
  'body': "import { className } from '@ember-decorators/component;'"

If you are okay with supporting ember-decorators's import statements in this plugin, I can send you PR.

@mattmcmanus
Copy link
Owner

Hey @axyxnz, thanks for this! I've been hesitant to include addon snippets in this package, as there is already a ton of imports already. Do you know if the ember-decorators package will become part of the default blueprint in octane?

@jrock2004
Copy link
Contributor

Yes, decorators will be

@axyxnz
Copy link
Author

axyxnz commented Feb 3, 2019

Yes, ember-decorators package will become part of Octante blueprint. However, import statements' from value might change.

As a developer, I would like to install a single atom plugin that enables autocompleting feature for Ember ecosystem (Ember, Ember Data, Ember-Glimmer integration, etc.). Finding and installing atom plugins to figure out which one autocompletes what is kind of annoying.

I am not sure whether you would want this plugin to be that plugin that supports Ember ecosystem. If that's not what you imagined to be future of this plugin, feel free to close this issue.

@mattmcmanus
Copy link
Owner

@axyxnz That's helpful. I'm fine with adding default blueprint addons. I've been hesitant to add other ones. This addon introduces enough snippets as it is and I want to make sure they're all as applicable as possible.

I'll try to get this merged in tomorrow.

@axyxnz
Copy link
Author

axyxnz commented Feb 11, 2019

Don't merge yet. I made few changes in local but I have not updated PR yet. I'll update PR tomorrow and verify all import statements. Thanks.

@manoharank
Copy link

@mattmcmanus @axyxnz Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants