-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ember-decorators package's import statements #54
Comments
Hey @axyxnz, thanks for this! I've been hesitant to include addon snippets in this package, as there is already a ton of imports already. Do you know if the ember-decorators package will become part of the default blueprint in octane? |
Yes, decorators will be |
Yes, ember-decorators package will become part of Octante blueprint. However, import statements' As a developer, I would like to install a single atom plugin that enables autocompleting feature for Ember ecosystem (Ember, Ember Data, Ember-Glimmer integration, etc.). Finding and installing atom plugins to figure out which one autocompletes what is kind of annoying. I am not sure whether you would want this plugin to be that plugin that supports Ember ecosystem. If that's not what you imagined to be future of this plugin, feel free to close this issue. |
@axyxnz That's helpful. I'm fine with adding default blueprint addons. I've been hesitant to add other ones. This addon introduces enough snippets as it is and I want to make sure they're all as applicable as possible. I'll try to get this merged in tomorrow. |
Don't merge yet. I made few changes in local but I have not updated PR yet. I'll update PR tomorrow and verify all import statements. Thanks. |
@mattmcmanus @axyxnz Any update? |
Hey,
As Ember marketing team is generating buzz around Ember Octane Edition, many users are trying out Ember's new features. It would be awesome to allow users autocomplete
ember-decorators
's import statements to make user's experience better.Ember Decorators API Documentation:
https://ember-decorators.github.io/ember-decorators/
import { ... } from '@ember-decorators/component'
import-ember-decorators-component.cson
import { ... } from '@ember-decorators/controller'
import-ember-decorators-controller.cson
import { ... } from '@ember-decorators/data'
import-ember-decorators-data.cson
import { ... } from '@ember-decorators/object'
import-ember-decorators-object.cson
import { ... } from '@ember-decorators/object/computed'
import-ember-decorators-object/-omputed.cson
import { ... } from '@ember-decorators/service'
import-ember-decorators-service.cson
ember-decorators
import statements will haveimdec
prefix.ember-decorators
import statements will be distinguish by#EDAE49
color. See Previewi.e.
snippets/import-ember-decorators-object.cson
If you are okay with supporting
ember-decorators
's import statements in this plugin, I can send you PR.The text was updated successfully, but these errors were encountered: