Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expectations should only stub out server requests #127

Open
juanca opened this issue Feb 27, 2018 · 0 comments
Open

Expectations should only stub out server requests #127

juanca opened this issue Feb 27, 2018 · 0 comments

Comments

@juanca
Copy link
Contributor

juanca commented Feb 27, 2018

It seems that the addition of feature_name as a request option (for analytics purposes) introduced a failing case when a filter had the key of feature_name.

I think enabling expectations would have caught this since it compares the actual versus expected load options. However, digging into it, I was not able to create a brainstem-js only failing case because the expectations kick in before the custom sync logic. If we were to push the expectations a bit further down the code path, we should be able to capture all the options presented to Backbone.sync and do a nut-and-bolts comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant