New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag's with external ids can't be removed #239

Open

ErikDakoda opened this issue Jun 28, 2015 · 0 comments

ErikDakoda commented Jun 28, 2015

The problem is here:

$el.find("#" + newTagRemoveId).on("click", $self, function (e) {
  e.preventDefault();
  var TagIdToRemove = parseInt($(this).attr("TagIdToRemove"));
  privateMethods.spliceTag.call($self, TagIdToRemove, e.data);
});

The id of the tag to remove is not numeric, so using parseInt in line 3 always results in TagIdToRemove to be NaN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment