Skip to content

Commit 2d49d75

Browse files
committed
Remove windows for publish actions as it's buggy right now
1 parent 3073fc3 commit 2d49d75

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ insert_final_newline = true
1111
trim_trailing_whitespace = true
1212

1313
[*.{cs,vb}]
14-
dotnet_diagnostic.CA1859.severity = none
14+
dotnet_diagnostic.CA1859.severity = none
1515

1616
###############################
1717
# C# Coding Conventions #

.github/workflows/publish.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
os: [macos-latest, ubuntu-latest, windows-latest]
19+
os: [
20+
macos-latest,
21+
ubuntu-latest,
22+
#windows-latest
23+
]
2024

2125
runs-on: ${{ matrix.os }}
2226

@@ -190,13 +194,10 @@ jobs:
190194
- name: Checkout code
191195
uses: actions/checkout@v4.2.2
192196

193-
# TODO: It'd be perfect if we could match final artifacts to the platform they target, so e.g. linux build comes from the linux machine
194-
# However, that is currently impossible due to https://github.com/dotnet/msbuild/issues/3897
195-
# Therefore, we'll (sadly) pull artifacts from Windows machine only for now
196-
- name: Download generic artifact from windows-latest
197+
- name: Download generic artifact from ubuntu-latest
197198
uses: actions/download-artifact@v4.1.8
198199
with:
199-
name: windows-latest_${{ env.PLUGIN_NAME }}-generic
200+
name: ubuntu-latest_${{ env.PLUGIN_NAME }}-generic
200201
path: out
201202

202203
- name: Unzip and copy generic artifact

ASFFreeGames/ASFFreeGamesPlugin.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public async Task OnASFInit(IReadOnlyDictionary<string, JsonElement>? additional
107107

108108
public Task OnUpdateProceeding(Version currentVersion, Version newVersion) => Task.CompletedTask;
109109

110-
public void CollectGamesOnClock(object? source) {
110+
public async void CollectGamesOnClock(object? source) {
111111
CollectIntervalManager.RandomlyChangeCollectInterval(source);
112112

113113
if (!Context.Valid || ((Bots.Count > 0) && (Context.Bots.Count != Bots.Count))) {
@@ -142,7 +142,7 @@ public void CollectGamesOnClock(object? source) {
142142
if (!cts.IsCancellationRequested) {
143143
string cmd = $"FREEGAMES {FreeGamesCommand.CollectInternalCommandString} " + string.Join(' ', reorderedBots.Select(static bot => bot.BotName));
144144
#pragma warning disable CS1998
145-
OnBotCommand(null!, EAccess.None, cmd, cmd.Split()).GetAwaiter().GetResult(); // TODO use async
145+
await OnBotCommand(null!, EAccess.None, cmd, cmd.Split()).ConfigureAwait(false);
146146
#pragma warning restore CS1998
147147
}
148148
}

0 commit comments

Comments
 (0)