Merge pull request #183 from maxmind/greg/eng-1019

Check MMDB_get_metadata_as_entry_data_list return value

Author: horgh

.github/workflows/address-sanitizer.yml

@@ -4,6 +4,9 @@ on:
   pull_request:
   schedule:
     - cron: '13 15 * * SUN'
+
+permissions: {}
+
 jobs:
   build:
     name: Address Sanitizer

.github/workflows/clang-analyzer.yml

@@ -6,6 +6,8 @@ on:
   schedule:
     - cron: '3 15 * * SUN'
 
+permissions: {}
+
 jobs:
   clang-analyzer:
     name: Clang Static Analysis

.github/workflows/codeql-analysis.yml

@@ -8,6 +8,8 @@ on:
   schedule:
     - cron: '0 18 * * 0'
 
+permissions: {}
+
 jobs:
   CodeQL-Build:
 

.github/workflows/release.yml

@@ -10,6 +10,8 @@ on:
     types:
       - published
 
+permissions: {}
+
 jobs:
   build_wheels:
     name: Build wheels on ${{ matrix.os }}

.github/workflows/test-libmaxminddb.yml

@@ -6,6 +6,8 @@ on:
   schedule:
     - cron: '3 15 * * SUN'
 
+permissions: {}
+
 jobs:
   build:
 

.github/workflows/test.yml

@@ -6,6 +6,8 @@ on:
   schedule:
     - cron: '3 15 * * SUN'
 
+permissions: {}
+
 jobs:
   build:
 

.github/workflows/zizmor.yml

@@ -6,6 +6,8 @@ on:
   pull_request:
     branches: ["**"]
 
+permissions: {}
+
 jobs:
   zizmor:
     name: zizmor latest via PyPI

HISTORY.rst

@@ -7,6 +7,8 @@ History
 ++++++++++++++++++
 
 * The vendored ``libmaxminddb`` has been updated to 1.12.2.
+* The C extension now checks that the database metadata lookup was
+  successful.
 
 2.6.3 (2025-01-09)
 ++++++++++++++++++

extension/maxminddb.c

@@ -351,7 +351,14 @@ static PyObject *Reader_metadata(PyObject *self, PyObject *UNUSED(args)) {
     }
 
     MMDB_entry_data_list_s *entry_data_list;
-    MMDB_get_metadata_as_entry_data_list(mmdb_obj->mmdb, &entry_data_list);
+    int status =
+        MMDB_get_metadata_as_entry_data_list(mmdb_obj->mmdb, &entry_data_list);
+    if (status != MMDB_SUCCESS) {
+        PyErr_Format(MaxMindDB_error,
+                     "Error decoding metadata. %s",
+                     MMDB_strerror(status));
+        return NULL;
+    }
     MMDB_entry_data_list_s *original_entry_data_list = entry_data_list;
 
     PyObject *metadata_dict = from_entry_data_list(&entry_data_list);