Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

props supports.css #5

Open
woodcox opened this issue May 19, 2023 · 5 comments
Open

props supports.css #5

woodcox opened this issue May 19, 2023 · 5 comments

Comments

@woodcox
Copy link
Contributor

woodcox commented May 19, 2023

Hi, it looks like you could include the open props package called supports.css. I presume Adam added this one fairly recently as it’s missing from your repo.

Would you be open to a pull request for this?

@woodcox
Copy link
Contributor Author

woodcox commented May 20, 2023

Having looked further at open props GitHub repo I’ve realised that it’s not in there index.css or index.js file either. So I understand why you didn’t include it.

@woodcox woodcox closed this as completed May 20, 2023
@mayank99
Copy link
Owner

mayank99 commented May 25, 2023

I'm still open to adding it; looks quite handy. However, the approach will need to differ. Instead of media queries or custom properties, we'd want to make them mixins that use @supports and @content.

For example:

@mixin safari-only {
  @supports (-apple-pay-button-style: inherit) {
    @content;
  }
}

@mayank99 mayank99 reopened this May 25, 2023
@woodcox
Copy link
Contributor Author

woodcox commented Jun 16, 2023

I've realised there is no props.supports.js file in the src of open-props git repo, so this will need to wait until one is created.

@mayank99
Copy link
Owner

we can always read the contents of the css file and extract the values from there

@woodcox
Copy link
Contributor Author

woodcox commented Jun 16, 2023

Yeah, I've opened an issue on open-props. I'll give it a bit of time to see if it was an oversight first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants