Improve coverage

mbarbin · Aug 22, 2024 · fd9e8e7 · fd9e8e7
1 parent 6a32cdf
commit fd9e8e7
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/src/fingerboard_location.ml b/src/fingerboard_location.ml
@@ -17,8 +17,12 @@
 (*  along with Fingerboard. If not, see <https://www.gnu.org/licenses/>.          *)
 (**********************************************************************************)
 
-type t =
-  { fingerboard_position : Fingerboard_position.t
-  ; string_number : Roman_numeral.t
-  }
-[@@deriving compare, equal, hash, sexp_of]
+include struct
+  [@@@coverage off]
+
+  type t =
+    { fingerboard_position : Fingerboard_position.t
+    ; string_number : Roman_numeral.t
+    }
+  [@@deriving compare, equal, hash, sexp_of]
+end
diff --git a/src/frequency.ml b/src/frequency.ml
@@ -17,10 +17,18 @@
 (*  along with Fingerboard. If not, see <https://www.gnu.org/licenses/>.          *)
 (**********************************************************************************)
 
-type t = float [@@deriving compare, equal, hash, sexp_of]
+include struct
+  [@@@coverage off]
+
+  type t = float [@@deriving compare, equal, hash, sexp_of]
+end
+
+let check_exn f =
+  if Float.compare f 0. < 0 then raise_s [%sexp "Out of bounds", [%here], (f : float)]
+;;
 
 let of_float_exn f =
-  if Float.compare f 0. < 0 then raise_s [%sexp "Out of bounds", [%here], (f : float)];
+  check_exn f;
   f
 ;;
 

diff --git a/src/octave_designation.ml b/src/octave_designation.ml
@@ -17,4 +17,8 @@
 (*  along with Fingerboard. If not, see <https://www.gnu.org/licenses/>.          *)
 (**********************************************************************************)
 
-type t = int [@@deriving compare, equal, hash, sexp_of]
+include struct
+  [@@@coverage off]
+
+  type t = int [@@deriving compare, equal, hash, sexp_of]
+end