Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant use cargo +nightly build --release #50

Open
watsonj8atwit opened this issue Jul 10, 2024 · 6 comments
Open

Cant use cargo +nightly build --release #50

watsonj8atwit opened this issue Jul 10, 2024 · 6 comments

Comments

@watsonj8atwit
Copy link

Screenshot 2024-07-10 191928

@adomaitisc
Copy link

adomaitisc commented Jul 21, 2024

The issue is with the private_in_public lint.

You can remove the line that contains it in rust/algebra/lib.rs.
Edit: rust/algebra/src/lib.rs.

lib.rs file

some stuff...

#![deny(
    unused_must_use,
    unused_mut,
    unused_unsafe,
            private_in_public,  < < <  Remove this line :)  < < < < < < < < <
    unsafe_code
)]

some more stuff...

@watsonj8atwit
Copy link
Author

i did remove that line and in my opinion i think not doing nightly rustup might fix it running a current version of rust should fix the issue did not test it yet though

@watsonj8atwit
Copy link
Author

i remove the line last week and still had issues

@adomaitisc
Copy link

That line occurs in another file as well, then it asked for llvm config.

I managed to run the tests and benchmark, then it was possible to perform the inference with one of the models in the repository.

The tests and benchmark look really odd tho, but they aren't exiting with an error.

@watsonj8atwit
Copy link
Author

I was able to follow the instructions up to the build and test phase. However, when integrating TensorBoard, running the model, and extracting weights, I encountered an error. I suspect that this GitHub repository hasn't been thoroughly tested with a fresh installation in the past two years, leading to compatibility issues. I appreciate the authors' initial work on this proof of concept but understand they might have moved on to other projects.

@watsonj8atwit
Copy link
Author

o to fix llvm config do this
LVM Configuration:

The warning about llvm-config --prefix indicates that the LLVM configuration is missing. You need to install LLVM and set the LLVM_CONFIG_PATH environment variable.

sudo apt-get install llvm
export LLVM_CONFIG_PATH=$(which llvm-config)

Compiler Flags:

Check if the compiler flags or environment variables are set correctly. The missing CXX variable indicates the C++ compiler might not be properly specified. Set the appropriate compiler in your environment:

export CXX=g++

then when in delphi/rust do
cargo clean
then run build again

also make sure your memory as much and you can reasonable give it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants