We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The git rev-parse --short HEAD below resolves to Git hash
git rev-parse --short HEAD
go-httpbin/Makefile
Lines 3 to 4 in 34a21a3
Shouldn't the VERSION be based on Git tag, that is, git describe --tags --abbrev=0?
VERSION
git describe --tags --abbrev=0
This makes me wonder, is this VERSION actually used for the image tagging?
Perhaps Docker images are tagged following this instruction?
go-httpbin/DEVELOPMENT.md
Lines 93 to 95 in 34a21a3
If my understanding is correct and there is room for improvement indeed, I can propose PR.
The text was updated successfully, but these errors were encountered:
feat: Add /version endpoint reporting build and version info
b2d08f4
Refs: - mccutchen#188 - mccutchen#190 Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
No branches or pull requests
The
git rev-parse --short HEAD
below resolves to Git hashgo-httpbin/Makefile
Lines 3 to 4 in 34a21a3
Shouldn't the
VERSION
be based on Git tag, that is,git describe --tags --abbrev=0
?This makes me wonder, is this
VERSION
actually used for the image tagging?Perhaps Docker images are tagged following this instruction?
go-httpbin/DEVELOPMENT.md
Lines 93 to 95 in 34a21a3
If my understanding is correct and there is room for improvement indeed, I can propose PR.
The text was updated successfully, but these errors were encountered: